From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-39883-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18798 invoked by alias); 9 Nov 2016 08:08:07 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 39883
Received: (qmail 18395 invoked from network); 9 Nov 2016 08:08:07 -0000
X-Qmail-Scanner-Diagnostics: from mail-vk0-f44.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.213.44):SA:0(0.0/5.0):. 
 Processed in 0.561898 secs); 09 Nov 2016 08:08:07 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_PASS,T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.44 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=LDYm3xG7KTDnbK6e3ttaPOCXHiLmEwJsQ4k6cAWQZdY=;
        b=F7geDNFE15WgLckx9TMgBW6kAUJj3Q9x3ZqsSzFceH+VKZuRv0Go5+blh0SOlh88Gh
         repZdTHNt7m5ZxSmYBZcfFxQQ6lwpXXErufwd5RHSK417n9KNOCdfi281LEArTBQshuW
         lvTklnzgKAd+WAFxYl6NqEjG+qhdwmI8HgnGMh8qQ7fwT5aZd9Kw0nOO/cZ91We+YT6a
         MD3idbchCNI/I5N5MVRqov0ROymjSaXXz3nFDJhuumwBzGBlxssF+CdJC0oSbONYEx8W
         vqSDuyxx6mO5DvxY+hWpKOhcA5f7oGEYL3GrIxgQxLGmELHDEM6DMOvd2Vst2eypAvAx
         JELw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=LDYm3xG7KTDnbK6e3ttaPOCXHiLmEwJsQ4k6cAWQZdY=;
        b=FpKhBsgAqRioXG77BHnWRVdJOhxA2BxJ17wvxb228j1g9Dqgmcwv8qCKzVVFZptr40
         DOG1WauP/VCRx32iFCI+C5zXO8tjhRFIxRo+OWOI9Dh4HATfycpF0803rYMMHsorvdsR
         FHrl3Cqk9C6G9Rxpvzb4iwGawLrlFUNNNwaxg/j2qHj4/9b3vVER8SwLo2OXZ2ACuozB
         IfQIO5QtdSQPT8uTYAugmrgVFFJuBnAeuDyI5Z9jX6ZHi12Q7z4AQckgs/GZSGT6TUh6
         U5scnny0x7hBZxrufLA7cLPfXlsPkG/QfwDoO/J3ZGEJACQJmYb8hQ1Nz3bSqRgE5sov
         3FqA==
X-Gm-Message-State: ABUngvf0RetXvc0eKdf0pnH7x7A3dqR/PIUQLVBxw2ndwWYEeRAXMMWnSB5qIYozgjMa8Q==
X-Received: by 10.31.203.3 with SMTP id b3mr2384944vkg.131.1478675475792;
        Tue, 08 Nov 2016 23:11:15 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <161108231113.ZM8160@torch.brasslantern.com>
Date: Tue, 8 Nov 2016 23:11:13 -0800
In-Reply-To: <1478635899.1897979.781551353.05792438@webmail.messagingengine.com>
Comments: In reply to Sebastian Gniazdowski <psprint@fastmail.com>
        "[PATCH] Optimization of getarrvalue()" (Nov  8, 12:11pm)
References: <1478635899.1897979.781551353.05792438@webmail.messagingengine.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: Sebastian Gniazdowski <psprint@fastmail.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] Optimization of getarrvalue()
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Nov 8, 12:11pm, Sebastian Gniazdowski wrote:
}
} Interesting that some tests fail (e.g. ./Y03arguments.ztst) if I here
} duplicate nular instead of doing:
} 
}     } else if (v->end <= v->start) {
}         s = arrdup_max(s, 1);
}         s[0] = NULL;
} 
} like in the original code.

Looking at this more closely, that's because nular isn't actually zero
length array, it's an array with a single empty string value.  If you
leave out the s[0]=NULL assignment you're changing the results.