From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24107 invoked by alias); 9 Nov 2016 17:08:13 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39893 Received: (qmail 27224 invoked from network); 9 Nov 2016 17:08:13 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.175):SA:0(0.0/5.0):. Processed in 0.814381 secs); 09 Nov 2016 17:08:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.175 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=SLVgFkB+WoQ4CGwzce8lt/F4XRt3r5w6mk4xVqodUwA=; b=up+S30MOpQkJ6ChoKPOGBUozeGwJxchUobAS7U+nfXVU/ZBN6A2631cqpI5kluYv5u ZyqGB/8lS8iAwwZTNRd8qd4B7AAk+mk5cSm7I96eqQflfZuv0S8SIbcX80wJzevMruFf BBIGvc/Jqdyf0yMp2hXRpVesItzuo3ZlVUscJvP1sPdASHtvDkoCh30PgTqpU5gvRK20 iqak8dRL8zLrkn5RsDJANprcd1HOrabf6ORKrBCYgU/z25ayYvFJOgLBI2dR0w0MgQNO EdOSJTi5rmQIoqsliQpg7ZUIGTf4kHlJF3uVhkt7XzpG/YE8GIeYaJ7XQmufVCsBgDq3 6cCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=SLVgFkB+WoQ4CGwzce8lt/F4XRt3r5w6mk4xVqodUwA=; b=H2cgBCLhabJxjaDIWB5NqRp1WyaJTiZbU5hrNGBH2fTCInKpUJtQHfvpat2+bqYTC1 UMz8vMMebYqivY28Gg2PYY0k/W8qxSMTj+t2Pp+e6aeYbiTZ6Z7G/O+yYfGkxoyy+ZIh jl5KtMgzkJLlmJ9jFigGt/Bo1dE0pEzWeYtFK1+YJ04DDpE7JW8w6kWknQGpOOpkRGMm kFsO2f1YO+qX+rzdD5w8Y7wrws2WN0H9+G1U6UVZiA1S9QrQ73UTbUPTSgxb5oOWltvL qjbgDFtem/W986LVEwKAplakk38I3xTbxAcWiJHxQN2rIAMV+lFbT0kUjR6wP3GMdkTR QZuQ== X-Gm-Message-State: ABUngvciKeMs7ilt3ZlJQzbmHpbgN2PhiFkjS0+IAvnUcvYBQWtNwbuyTKOA7s0Tnmjsvg== X-Received: by 10.159.33.136 with SMTP id 8mr160215uac.153.1478707410539; Wed, 09 Nov 2016 08:03:30 -0800 (PST) From: Bart Schaefer Message-Id: <161109080328.ZM6075@torch.brasslantern.com> Date: Wed, 9 Nov 2016 08:03:28 -0800 In-Reply-To: <20161109114207.6b929440@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: [PATCH] Optimization of getarrvalue()" (Nov 9, 11:42am) References: <1478635899.1897979.781551353.05792438@webmail.messagingengine.com> <20161109114207.6b929440@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] Optimization of getarrvalue() MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Nov 9, 11:42am, Peter Stephenson wrote: } } + } else if (v->end <= v->start) { } + s = arrdup_max(s, 1); } + s[0] = NULL; Might as well make it obvious? diff --git a/Src/params.c b/Src/params.c index ef72cba..6736aa5 100644 --- a/Src/params.c +++ b/Src/params.c @@ -2293,10 +2293,9 @@ getarrvalue(Value v) /* Null if 1) array too short, 2) index still negative */ if (arrlen_lt(s, v->start) || v->start < 0) { - s = arrdup(nular); + s = arrdup_max(nular, 1); } else if (v->end <= v->start) { - s = arrdup_max(s, 1); - s[0] = NULL; + s = arrdup_max(nular, 0); } else { /* Copy to a point before the end of the source array: * arrdup_max will copy at most v->end - v->start elements,