From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Tiny optimization to arrdup_max()
Date: Mon, 14 Nov 2016 10:47:43 -0800 [thread overview]
Message-ID: <161114104743.ZM23434@torch.brasslantern.com> (raw)
No need for arrlen() if we're just truncating.
diff --git a/Src/utils.c b/Src/utils.c
index cceaf4c..52201a9 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -4244,9 +4244,10 @@ mod_export char **
arrdup_max(char **s, unsigned max)
{
char **x, **y, **send;
- int len;
+ int len = 0;
- len = arrlen(s);
+ if (max)
+ len = arrlen(s);
/* Limit has sense only if not equal to len */
if (max > len)
reply other threads:[~2016-11-14 18:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161114104743.ZM23434@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).