From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7304 invoked by alias); 19 Nov 2016 18:16:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39987 Received: (qmail 12626 invoked from network); 19 Nov 2016 18:16:49 -0000 X-Qmail-Scanner-Diagnostics: from mail-yb0-f193.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.193):SA:0(-0.0/5.0):. Processed in 0.561481 secs); 19 Nov 2016 18:16:49 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.193 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject:cc :mime-version; bh=vbQVxY0uVkfixsXa1znOsJdCaEilRxsWhxUeNQS4D0s=; b=UckoGZULYCz/5SRGpWy7+vjqrk/uiF6Zvw+KAWayh7qffQ4U/hBNzeHJYSBWEmmrFR NmsH5WrhWOTSZ8GhLKBiU9kMRnHBWlRB1f2j2ZebZB53JEZBW3nzVOWVGH+E3MxhMuOM tc1YBmygymct2HPoZGi/iquWd6uIw+LbLBtC/2Kc4/2opyq1mF+AoQ4aEUrCn0Yrmws4 xbvpL4y8cbGbIaVh4uRZxndcu/NvKgdvIQKsmV75io+5sYWjmbFpn0AquxUk4I1OzkEa LODuId0ENlSvm8RHo44Mu8bpTEsN7VlpAfpWzSXhIkIWZkDjhv8hnuudNO5MuIUAKoJ1 pSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:cc:mime-version; bh=vbQVxY0uVkfixsXa1znOsJdCaEilRxsWhxUeNQS4D0s=; b=CpzMRMz9fO2R28n0uc5CW43qf5TIWWsLCy5KIHGErfeLHpHDgezYIKyEu60ValEmQJ ZPiHICtcjAwMumuM83avoma/B1pFPdI2YP2RGMu/kIi0XimH3c7WnOgxTARJ+iosb8BR ehfiBFKgWQdR3aOR1VxLlRT4FnJwaUF40vGtSf3cU7k5T7B9fxVQXO6hiF4BkeNtk+ZB btvIwU8cPUi5oipDlh0I320JBphxUVOaAHgkwR9LpG6udYymSxdWz/4N+RVOIyinvj3k GLRhN0TjTjcRuhkhSyD9tqTM0qf4+GKvPKjBqC0pfKDgaD7oqh9VpjyFm/vrvGn9k7iC 0Ryg== X-Gm-Message-State: AKaTC03hv2Pt8orYWkL48UjJEXv1G1JOTZI1X23b21Iwa50sZmdVTBNp7j0JZOe8WIGTDw== X-Received: by 10.37.99.196 with SMTP id x187mr2140101ybb.173.1479578405657; Sat, 19 Nov 2016 10:00:05 -0800 (PST) From: Bart Schaefer Message-Id: <161119100023.ZM13994@torch.brasslantern.com> Date: Sat, 19 Nov 2016 10:00:23 -0800 In-Reply-To: <20161119075542.GA6750@fujitsu.shahaf.local2> Comments: In reply to Daniel Shahaf "Re: Bug#844710: Fwd: Re: [Pkg-zsh-devel] Bug#844710: autocorrection suggested rm for typing mr without typing "y"" (Nov 19, 7:55am) References: <3574167.p9ErITdPmY@merkaba> <20161119075542.GA6750@fujitsu.shahaf.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Bug#844710: Fwd: Re: [Pkg-zsh-devel] Bug#844710: autocorrection suggested rm for typing mr without typing "y" Cc: 844710@bugs.debian.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Nov 19, 7:55am, Daniel Shahaf wrote: } Subject: Re: Bug#844710: Fwd: Re: [Pkg-zsh-devel] Bug#844710: autocorrecti } } Martin Steigerwald wrote on Fri, Nov 18, 2016 at 14:15:51 +0100: } > So two fixes to consider: } > } > 1) Don't confirm on space, as thats to easy to trigger accidentally. :) } } The code confirms on both tabs (since commit 7f1ce570) and spaces (since } before CVS). Does anyone know a reason for doing this? If you have a look at the zsh-workers article referenced by 7f1ce570, you'll see that both space and tab date from time immemorial; the patch in 7f1ce570 actually REMOVES the interpretation of tab as "yes" from the NO_RM_STAR_SILENT option, it didn't change CORRECT handling. Why it's this way probably has more to do with Paul Falstad's typing habits than anything else. If you're used to hitting space or tab at a completion, and most of the time you believe the correction, then you probably want space and tab to mean "go ahead" anytime the shell is waiting for something. Notice the RM_STAR_WAIT option for a similar situation. While I don't use CORRECT and therefore personally don't much care what this prompt does, I question whether one person remarking about this after 25+ years of it being the way it has been, is a sufficient reason for us to immediately change it.