Re: zsh-5.2-test-3

[Bart Schaefer <schaefer@brasslantern.com>]

[Moving to -workers]

On Dec 10,  6:07pm, Ray Andrews wrote:
} Subject: Re: zsh-5.2-test-3
}
} On 12/09/2016 11:54 AM, Peter Stephenson wrote:
} >
} > 5.2-test-3 is in
} >   
} > http://www.zsh.org/pub/development/
} >
} >
}      Seems to have fired up ok, however:

What is the platform where you are compiling?

} 
}     builtin.c:5041:11: warning: "cursplit" may be used uninitialized in
}     this function [-Wmaybe-uninitialized]
} 
}     compmatch.c:774:15: warning: "savl" may be used uninitialized in
}     this function [-Wmaybe-uninitialized]

These are both spurious -- each of these variables shadows another which
is always used/tested first and which is not used uninitialized.  May as
well shut up the warnings, though.

}     $ make check
} 
}     ./V10private.ztst: starting.
}     Pattern match failed:
} 
} 

There ought to be more output than that ... please run

$ ZTST_verbose=2 make check TESTNUM=V10

} BTW, if there a 'make check' that only shows errors or warnings?  No 
} need to see all the stuff that's fine.

No, but as shown above you can run specific tests if you already know
the others to be OK.


diff --git a/Src/Zle/compmatch.c b/Src/Zle/compmatch.c
index f82f00e..aedf463 100644
--- a/Src/Zle/compmatch.c
+++ b/Src/Zle/compmatch.c
@@ -674,7 +674,7 @@ match_str(char *l, char *w, Brinfo *bpp, int bc, int *rwlp,
 		     *
 		     * operation.  Similar to savw.
 		     */
-		    char savl;
+		    char savl = 0;
 		    /*
 		     * The anchor on this end.
 		     */
diff --git a/Src/builtin.c b/Src/builtin.c
index e641a97..65e0cb1 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -4092,7 +4092,7 @@ bin_print(char *name, char **args, Options ops, int func)
     char *start, *endptr, *c, *d, *flag, *buf = NULL, spec[14], *fmt = NULL;
     char **first, **argp, *curarg, *flagch = "'0+- #", save = '\0', nullstr = '\0';
     size_t rcount = 0, count = 0;
-    size_t *cursplit, *splits = 0;
+    size_t *cursplit = 0, *splits = 0;
     FILE *fout = stdout;
 #ifdef HAVE_OPEN_MEMSTREAM
     size_t mcount;