From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21138 invoked from network); 28 Mar 2022 14:49:41 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 28 Mar 2022 14:49:41 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1648478981; b=llowLORLx9Xc0gPrsDOPXnfvydOg0wpq8ranUfonKHwmHvLSNP9qxtuv8s5f8S8Icwm4UPuma0 ZJ0aG2E2ZoVud6PPXJ3FG+0nAJcqbeOXdon1sBak4x5jadY5YI4IKc33HYxcFr5QHC+hgHm72k 94atWn4hfXNgqfAPfNfsciJOS5Q5enyfo2onoua8k9qZur7I3RL23THh56+L0eWTYnn07Byy6P cDcYO7y+dJrFAohfMfRPZMtvzlScveaWAMkuo3lrVjfoJS3DgGzkZJOhtO/a4kzvjFMQ3/d7oS 9hFpHpXVBsAhh6rtpNtzXVdGbjoc7Th/Bf+wsQaGVoK7Zg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq1.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.96; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1648478981; bh=0jLzBw2ruuOxloAcqV8HwQS0hd5iZiNjBoZEOWrxAmU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=rbkt7ZJJq3NNT6qQ4BFQUSwSTyceL/68BwUHjBvtxrwUY8vS7P+IQPENm0FN090Eg5E765T0XQ BOxRdVkiFA0WACH6Kl+8KFycKQ3Pqik/rcOOHvPaojQil3wNrNarf9pscIQgm1m4HquVagjcLh bUVznCIgp69Yo8tcAcjhCd8M5lyO4J7k8N7Kw08JdS1V2NFpZDd9rR/xT0zOdcroSVTURwQFCA rdqDf2epKR7KV0CjvEdoBMZYBrCMo4nZd1fZ/ft8pB4NH5G47EJndhJM8j89z5KE0XHCta+6lb w6/bDzYBSKIvjMLXX3sWUc4zzBdQEfpQoNjSqHulm6C3yA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=DlqcZ/ONhPe4S3RHY7ChMbKxpZf88pUMVi+agnsVBfg=; b=At5B+irYa3virQofBJrnMwoLy+ NYh4v+JBOVAnb7T3SvwlX98s0F/XB849fLJJX6uFGH6nwGhMiTqdNyprVxeOepbgizfadX1fumJTo A+af/C7X03yQqkDgRbvbPCxx27X1NE4tF1EW/jWYln5kDV+pb/lHJrBqABeZB/pzfDxZv9caj896W 9wV4T8kNhvbM9MC/u5AbR0DBxMeDTRpJEmfKRt1EyzCn8vfMn/5IY8CVzOtMRVF0LHRV8d9kas9nA b5d31DzfVHkgkxIM7MFpIw5QfsTTbUA4T0Y2R0UkTmfB4Hgo/MqiHOB4AbP04qCNOw/0PwXd9Zn8P Zqr1XApg==; Received: from authenticated user by zero.zsh.org with local id 1nYqge-000KOr-LL; Mon, 28 Mar 2022 14:49:40 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq1.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.96; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq1.tb.ukmail.iss.as9143.net ([212.54.57.96]:60326) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1nYqg6-000K67-Fj; Mon, 28 Mar 2022 14:49:06 +0000 Received: from [212.54.57.82] (helo=smtp3.tb.ukmail.iss.as9143.net) by smtpq1.tb.ukmail.iss.as9143.net with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqg6-0006z5-8I for zsh-workers@zsh.org; Mon, 28 Mar 2022 16:49:06 +0200 Received: from oxbe25.tb.ukmail.iss.as9143.net ([172.25.160.156]) by smtp3.tb.ukmail.iss.as9143.net with ESMTP id Yqg5n2qjyl7D1Yqg6nPdtl; Mon, 28 Mar 2022 16:49:06 +0200 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.156 X-CNFS-Analysis: v=2.4 cv=Xo7phHJ9 c=1 sm=1 tr=0 ts=6241cae2 cx=a_exe a=NA7IgXeTfPXpJV+SL5V8Rw==:117 a=wbvTLvLwOfMA:10 a=IkcTkHD0fZMA:10 a=7H6ixmLU1AQA:10 a=NLZqzBF-AAAA:8 a=q2GGsy2AAAAA:8 a=rvJXEpEtVuAhr_Fy9ycA:9 a=QEXdDO2ut3YA:10 a=wW_WBVUImv98JQXhvVPZ:22 a=z9dJwno5l634igLiVhy-:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1648478946; bh=0jLzBw2ruuOxloAcqV8HwQS0hd5iZiNjBoZEOWrxAmU=; h=Date:From:To:In-Reply-To:References:Subject; b=fcDiL2CHHIWQpucQX82l6fTtaY0Ovo/yS9ImVurruLvG8KEzVnakM4P02Z1imeKJ7 d1q/An9VHxEogaV9e3NDi8Py6Iogw8zbXe1KWdd+xF76iUmc/AYNonOSw28abwychn DYptjyu65aiC+EdGPo+OuJ6y0WJfSth50M7+utssyJgYIhZQxS5DwByYcihDspsLWz KMntw1jZGa6ZPqA58oLEwrHT7OWsLCztC8ksEkuCMv9S/uv0FUHaR5w79IgVRas0AH acDXLgWJDvWR8iw8Cew5XINfN/SPUWa6kfC2UcU3qWE0EZlnlaPGA+CMoMaFm6ljwh zK7h/oLnrSqdQ== Date: Mon, 28 Mar 2022 15:49:05 +0100 (BST) From: Peter Stephenson To: Zsh hackers list Message-ID: <1613542531.711035.1648478945973@mail2.virginmedia.com> In-Reply-To: <1409134730.698961.1648457237653@mail2.virginmedia.com> References: <1409134730.698961.1648457237653@mail2.virginmedia.com> Subject: Re: Crash on jobstates since workers/49783 (commit 6a8aa2a) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev72 X-Originating-IP: 147.161.167.85 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfA+wEx2DsWB5tJODUb1k/DweHeOlQetOK/mQ5mTqCPk47gyIPWXniCYkysFwiZj7Eym5/PrwVpJ4MyXiVzeatsxf1vtScFhL6UXHYmCLWcrCO8n9pZKD kpHlSZfZ6qOPJAM/pX8M97gm+Tg1IcmckShXZdYBJI7dwahUcc5tJOJmNywFGswp/QFBLNtfbReVQATJ41H9MvFs9ZNQHti1bBkG4bpAL9Tk+nLiaBqslUjC X-Seq: 49900 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > On 28 March 2022 at 09:47 Peter Stephenson wrote: > > On 27 March 2022 at 06:34 Bart Schaefer wrote: > > On Fri, Mar 25, 2022 at 3:32 PM Bart Schaefer wrote: > > > > > > The nested calls to zargs from runN all die with a SEGV on when running: > > > > > > wait ${${jobstates[(R)running:*]/#*:/}/%=*/} > > > > Minimal reproducer: > > > > % sleep 5 & > > [1] 171363 > > % ( wait ${${jobstates[(R)running:*]/#*:/}/%=*/} ) > > zsh: segmentation fault (core dumped) ( wait > > ${${jobstates[(R)running:*]/#*:/}/%=*/}; ) > > % > > $jobstates was still looking at the process structures which doesn't > work in the subshell. Previously, it didn't even look at the > main job state in a subshell. Obviously, the subshell doesn't know > the up-to-date state anyway, and can't actually manipulate it. > So probably the best we can do is report the last we knew about the > job state and ignore the process structures. This probably warrants > a bit of documentation. Just thinking the pukka way to do this is actually zero the PN fields in the saved job structure when we enter the subshell (unless we decide to preserve them properly, which is more work but should be possible). There's also a one-line test change unless we do go the extra mile with the process structures. pws