From: dana <dana@dana.is>
To: Zsh workers <zsh-workers@zsh.org>
Cc: dana <dana@dana.is>
Subject: Re: [PATCH] Completion: Add _bash, update _sh
Date: Sat, 9 Jun 2018 00:44:01 -0500 [thread overview]
Message-ID: <162A7C98-2EAB-4E72-8152-EF86E7D12D6A@dana.is> (raw)
In-Reply-To: <52421D97-B114-45A1-B547-30F4D6DAE162@dana.is>
Oh, PPPS:
On 9 Jun 2018, at 00:15, dana <dana@dana.is> wrote:
>+ args)
>+ if [[ -n ${opt_args[(i)s--[cs]]} ]]; then
>+ _files && ret=0
>+ else
>+ _normal && ret=0
>+ fi
>+ ;;
I wanted to mention (and probably should have in a comment) that my thinking
here was that you might do something like `bash /usr/bin/mycmd <tab>` and then
if mycmd had completion you'd want it handled as normal. On balance, it's
probably not *super* common for someone to explicitly call bash to execute a
script that has completion, so this might be undesirable — it'll cause custom
scripts that just happen to have the same name as a more popular command to be
completed as that command. So it could be preferable to just have an
unconditional '(-)*:: :_files' or whatever.
I don't feel strongly either way; feel free to edit if you do.
dana
prev parent reply other threads:[~2018-06-09 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 5:15 dana
2018-06-09 5:44 ` dana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162A7C98-2EAB-4E72-8152-EF86E7D12D6A@dana.is \
--to=dana@dana.is \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).