From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26988 invoked from network); 23 Nov 2021 06:46:41 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Nov 2021 06:46:41 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1637650001; b=CxhJefA5kjv/UFB8rn22z2V1E5Avnfg9iPWxteYmj+2AxADfPzp9TGT8hI445jcRZ61j2Slh0w 44jfmHAJaMZWkpOoptS34e7hRmWiUuj0yeDErcmnBhjSSszZbqysjBoQiDcjaXVSO/Y617RPjk XooLUG5FBNvrw+zQG04N98+96Mbpde3xP4LETQ/xYdGnr/zHEiGkzSQtWrwxc4o4fHZo7ZoJf1 CFyEmN1VHUBzL9bY7q3W+ozXkX26qw4BYPwRRKtMw4PihC+Zh1BNmFuRnJCsv58iq4BkFBH1Gt rOFzFn1y/tImtvh1eZh4lICwBceaw1cDToYktDbwRfrSxA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f48.google.com) smtp.remote-ip=209.85.167.48; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1637650001; bh=1jM1KvGJquefYWcQ54aoxuH4fSbYqXKXSNie7Wgcw90=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Message-ID:Date:Subject:To:From: Content-Type:DKIM-Signature:DKIM-Signature; b=oxqyn/bYk07hAWAU7xS0L/GfbgOav4EWSM9YjQKv2h1Ls+q6NXXvRc7hsfm63VTRB4mVXne8g7 CE/SR0CJjNq7C8pXy6zXB3pQIY+771io4j9GYo8DQbvuYAMpkc3zybB/SAdsQh+4MgaRl5c8is +/4Pt7cfjEEMrnb6/ynsBSmZEwyhNrPjCWoELCOgR5fbk4vQdg3If4xY+oZnDIVK7FFOL2CyW1 tySsXyKKK4CgjpE1JvalTd1ONR+PxuWzHshJI0cYj+nkn6NVXenXt5zOfu5JOvVHZpUqcFoawG e34vVolbtC0OkofZ8oZK2wwMTzyWhjaU5xjarNHBiRgTiw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding:Message-Id: Date:Subject:To:From:Content-Type:Reply-To:Cc:MIME-Version:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=FE++D192LAxIcbywK+OKTt6sx1GeuS6Vy8fmyOz65rA=; b=GwgjkwL+CrhvS6Dgt5NYRzTy12 UykDZuwaywL99rdj06vNSrzdRcSJnksDKr+u2F5Yn5MM05LTEXcgk63CAYAYefThKO41a4nRCxJFe zpJjqLHS/z2ucffQW++8HSVIBoIAJYCUUx8s1drhiam6Zlmnt3PRyUCXQLM4+7Iy2Pvl7HTtj7hN9 /Nmm6mhPpCBQ8zO0oV/gWlW92dSk7wCPlL01R+jD/WxPPGh/8QvO5hB9M4pbv6XPROlE4MI28eVeP /REQxha+yYQQoury6oQKJOauJnmEmOZ+de3aYKByDGiOQ7SNgV1R5siGn7hi5tbXeiCzePDAcdlWK YCSMTfaQ==; Received: from authenticated user by zero.zsh.org with local id 1mpPZf-0004Ue-N5; Tue, 23 Nov 2021 06:46:39 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f48.google.com) smtp.remote-ip=209.85.167.48; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f48.google.com ([209.85.167.48]:44866) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mpPZO-0004Dj-Od; Tue, 23 Nov 2021 06:46:23 +0000 Received: by mail-lf1-f48.google.com with SMTP id y26so88183698lfa.11 for ; Mon, 22 Nov 2021 22:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent :content-transfer-encoding; bh=FE++D192LAxIcbywK+OKTt6sx1GeuS6Vy8fmyOz65rA=; b=o+mZScbnTQkFv4aoLV7IYVlU13xkcd4bP4mwy889Opi1LF/ilapzjpzmmGSy89tGOh trV0UDWqiINr9Agryf6uWSr1SFcEve2WETCvxGxy3tQzxPkp/9xo7PzD30v4n6njFKyV z9l2Ee5DFrqIqIE7Vzfz+LBS8xfw75ZRkHkeEG2NMspqfcMmRwW/ItvAxzm4e1AzNwsC boyf/5iNRn6ltnZW33OL9P0rv3pLRkV8llmkmqhLB2MWJ4d2IU5/TmAH2lASPNEoA/wq rz/RePjmtB7EJI41/6pSpKsMvoEeezezVWYW1qqEhfkw4/1dAcdt7LeD7cq/MjadN2LT Y4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :content-transfer-encoding; bh=FE++D192LAxIcbywK+OKTt6sx1GeuS6Vy8fmyOz65rA=; b=R6fN/FqPinGghtTAxxtZE9Y9x/OaYXXLTkuuBQaLiV25SRj/PLff/sJXG2zMyT+CPB +jyrsaRh/+ru+x7+rPkHgq1P/D44FLsUGssxUoMc022VpUmGRG1dVdrx6JQ2RiBqogYf mre+y0t0TAa34JwYLFVBFBwuTwoRgH0N+7DWNAnmRD2c16EBufp1pI7G01JFBTx2yBU1 I+8CEJoCaH3NaW3EHngXMdxAuDb38zTDIsGQ3zrr82w9oAk0KovnUKhru/KcKzaOZUZL 8wpLq5woMLH5tTQbXCv4HAti6E28TMzeI1xVRkifngYtxUYZoDyrrncVpWU7F5K/GuPW cOQw== X-Gm-Message-State: AOAM5323Sgxsx8mdXg3US7y2xC8JFSS2oybz70FgqFTFd+f1nQW/lO24 onEQX08D/rp+yzN3gcFCkb9QjyUOKvFpDg== X-Google-Smtp-Source: ABdhPJyTBdntEHGqKbZrYsT8AHxUKVyZyzFe7LCchjEGuBrfg+1a52v9bH3DCpdxvemC7IrFrTZvOA== X-Received: by 2002:a19:6754:: with SMTP id e20mr2482212lfj.122.1637649981512; Mon, 22 Nov 2021 22:46:21 -0800 (PST) Received: from localhost (78-67-247-110-no2350.tbcn.telia.com. [78.67.247.110]) by smtp.gmail.com with ESMTPSA id e19sm1160130ljn.82.2021.11.22.22.46.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 22:46:21 -0800 (PST) Content-Type: text/plain; charset=UTF-8 From: =?utf-8?q?Claes_N=C3=A4st=C3=A9n?= To: zsh-workers Subject: [PATCH] Do not define _POSIX_C_SOURCE when checking for sigset_t on Solaris Date: Tue, 23 Nov 2021 07:46:20 +0100 Message-Id: <1637648446-sup-9516@debian9> User-Agent: Sup/1.0 Content-Transfer-Encoding: 8bit X-Seq: 49598 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Trying to compile zsh on Solaris 10 fails for me right after configuration due to misleading information in config.h The check for sigset_t fails, due to: configure:8654: checking for sigset_t configure:8673: gcc -c -Wall -Wmissing-prototypes -O2 conftest.c >&5 In file included from /usr/include/sys/types.h:17, from conftest.c:85: /usr/pkg/gcc8/lib/gcc/sparc64-sun-solaris2.10/8.4.0/include-fixed/sys/feature_tee sts.h:346:2: error: #error "Compiler or options invalid for pre-UNIX 03 X/Open aa pplications and pre-2001 POSIX applications" #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \ ^~~~~ conftest.c: In function 'main': conftest.c:90:10: warning: unused variable 'tempsigset' [-Wunused-variable] sigset_t tempsigset; ^~~~~~~~~~ configure:8673: $? = 1 Looking at the git history it seems _POSIX_C_SOURCE is defined to ensure configure works with systems using musl libc so the patch should not cause any issues as it's Linux only. Tried configuring on Solaris 11 as well and it still detects sigset_t. diff --git a/configure.ac b/configure.ac index 297a7482f..7494b3529 100644 --- a/configure.ac +++ b/configure.ac @@ -1135,7 +1135,9 @@ dnl Check for sigset_t. Currently I'm looking in dnl and . Others might need dnl to be added. AC_CACHE_CHECK(for sigset_t, zsh_cv_type_sigset_t, -[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#define _POSIX_C_SOURCE 200809L +[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#ifndef __sun + #define _POSIX_C_SOURCE 200809L +#endif #include #include ]], [[sigset_t tempsigset;]])],[zsh_cv_type_sigset_t=yes],[zsh_cv_type_sigset_t=no])]) AH_TEMPLATE([sigset_t],