zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 1/1] Squashed commit of the following:
Date: Wed, 30 May 2018 17:43:07 +0200	[thread overview]
Message-ID: <16604.1527694987@thecus> (raw)
In-Reply-To: <20180530124707.xp6loetwnplkypk2@NUC.doronbehar.com>

Doron Behar wrote:
> O.K, I used `ret` instead yet currently I don't see any use in this
> variable since I didn't structured the completion file with `return ret`
> at the end of any of the functions as I've seen in other completion
> functions I read.

You need something like it in the final function. You're calling
_arguments and ignoring the return status from it. This can break things
- approximate completion mostly.

It's only really that function where you need it.

> Jesus, using `zstyle` is complicated, I hope I'll master this skill one
> day..  Where can I find in the documentation more explanations about the
> relation between zstyle and completion functions?

It looks worse than it is. You can see the styles and contexts for a
particular completion by pressing Ctrl-X h instead of Tab. With a
numeric argument (Escape 1 for emacs mode) it provides more detail.

Oliver


  reply	other threads:[~2018-05-30 15:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26 16:14 [PATCH 0/1] *** Add luarocks completion *** doron.behar
2018-05-26 16:14 ` [PATCH 1/1] Squashed commit of the following: doron.behar
2018-05-28 10:48   ` Oliver Kiddle
2018-05-29 15:38     ` Doron Behar
2018-05-29 22:00       ` Oliver Kiddle
2018-05-30 12:47         ` Doron Behar
2018-05-30 15:43           ` Oliver Kiddle [this message]
2018-06-01  7:18             ` Doron Behar
2018-06-01 13:30               ` Doron Behar
2018-06-01 22:45                 ` Oliver Kiddle
2018-06-03 21:46                   ` Daniel Shahaf
2018-06-05 15:41                   ` Doron Behar
2018-06-07 15:59                     ` Oliver Kiddle
2018-06-07 16:20                       ` Doron Behar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16604.1527694987@thecus \
    --to=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).