From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12353 invoked from network); 22 Mar 2005 19:29:30 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 22 Mar 2005 19:29:30 -0000 Received: (qmail 32748 invoked from network); 22 Mar 2005 19:29:24 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 22 Mar 2005 19:29:24 -0000 Received: (qmail 25593 invoked by alias); 22 Mar 2005 19:29:21 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21052 Received: (qmail 25564 invoked from network); 22 Mar 2005 19:29:20 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 22 Mar 2005 19:29:20 -0000 Received: (qmail 32199 invoked from network); 22 Mar 2005 19:29:19 -0000 Received: from mail36.messagelabs.com (193.109.254.211) by a.mx.sunsite.dk with SMTP; 22 Mar 2005 19:29:12 -0000 X-VirusChecked: Checked X-Env-Sender: okiddle@yahoo.co.uk X-Msg-Ref: server-12.tower-36.messagelabs.com!1111519750!15277891!1 X-StarScan-Version: 5.4.11; banners=-,-,- X-Originating-IP: [158.234.9.163] Received: (qmail 7642 invoked from network); 22 Mar 2005 19:29:10 -0000 Received: from iris.logica.co.uk (158.234.9.163) by server-12.tower-36.messagelabs.com with SMTP; 22 Mar 2005 19:29:10 -0000 Received: from trentino.logica.co.uk ([158.234.142.59]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id j2MJTAV1006338 for ; Tue, 22 Mar 2005 19:29:10 GMT Received: from trentino.groupinfra.com (localhost [127.0.0.1]) by trentino.logica.co.uk (Postfix) with ESMTP id F38A43811A for ; Tue, 22 Mar 2005 20:28:49 +0100 (CET) X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: <200503222146.12289.arvidjaar@newmail.ru> From: Oliver Kiddle References: <200503121046.54826.arvidjaar@newmail.ru> <9029.1111424918@trentino.groupinfra.com> <200503222146.12289.arvidjaar@newmail.ru> To: zsh-workers@sunsite.dk Subject: Re: [PATCH] _fuser Solaris and SVR4 support Date: Tue, 22 Mar 2005 20:28:49 +0100 Message-ID: <16928.1111519729@trentino.groupinfra.com> X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 Andrey wrote: > well, except at it turned out it was impossible to complete file > name as first argument; also fuser takes more than one file. > > Is the following the right way to do it? Yes, that looks right. Only thing is that the descriptions passed to _alternative should be in the singular form - "signal" and "file" instead of "signals" and "files". That's our convention: you're only completing one file (though more than one may match and the next argument may also be a file). The "name" description for the final files should probably also be "file". I'm not posting another patch for that though. I suggest you just commit it. Oliver