From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6160 invoked by alias); 1 Jan 2017 19:20:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40256 Received: (qmail 26544 invoked from network); 1 Jan 2017 19:20:21 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f170.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.170):SA:0(-0.0/5.0):. Processed in 1.132698 secs); 01 Jan 2017 19:20:21 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.170 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=mJuuKsA0DPPhEr6C1fAzNHjTHuc1m4XD6KnS6lb6oPo=; b=ebdjS+BeIlvlHcdR1vBGMxgbdpLKWm5Abhv3VZjyzBeZ2pEI4iJMCU4EzYEHiN9Dga KTzNeYbz4yA3AncKEXDYScEQ9ROcCgmh2Pf5AS7goSlqZ57kxZ03LRd+cnI6nVeis0w2 a5EU8h1IqC9g1ZDKnQrCtY1nxGDNrrW0F/3B5DdEmCwTeNl9AdXURL39Z/fjHa/7YFS0 fiQ5Ei6AHNCLwfitopSlPHLmycHQnalOTHB37YEBe/KjJM9D9C5TkWLVKRctb2u6Fk65 vihthmqxyEcJ1HcNkBcP9uO3vsKFNqQ76G0vuwTBExmBdnYCAIWSI46OwfmFE9FtScdO tTuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=mJuuKsA0DPPhEr6C1fAzNHjTHuc1m4XD6KnS6lb6oPo=; b=E1k0AZ5yE4QZvXfzFHvjmIyW4Q8j3y80wyn3Rg+KnA5F8qn8cyULhElFXg6OZ4sZYH pO3GDI0O0IdaguWsf1heI/+BO8/Clk2Lgvbn6WOSWAiseoy/YpwLVoCVCJB/6W4rXTnJ bvG3mpTNXGKXl1K6QVHAmqL+0fzS99O3CJLubhckUsn8B3oUmau4K9LJCaMFjmACrUHm jr8OWv9Q6P6eYqUqmKav5y6EB7fHQb1YW3vBiyZpB06vreFu+usu7qCmgSt65dNWXI56 8xDD6HhMJBP9164fOvQVIFVbgPk7LSB3NbI537QVXe/9ln65+jO0EG0AKoYUWre0M3Gm wAwQ== X-Gm-Message-State: AIkVDXLq2QRyGYXq3uV6l4u9DksGyb8bXC2BCeojXAc6ocMF89oZ4iB71Nvli7vpM/ZqdA== X-Received: by 10.159.34.112 with SMTP id 103mr42365355uad.160.1483298411276; Sun, 01 Jan 2017 11:20:11 -0800 (PST) From: Bart Schaefer Message-Id: <170101112030.ZM28010@torch.brasslantern.com> Date: Sun, 1 Jan 2017 11:20:30 -0800 In-Reply-To: <20170101031034.GA15639@fujitsu.shahaf.local2> Comments: In reply to Daniel Shahaf "Re: Error in zshaddhistory() should not prevent command from running" (Jan 1, 3:10am) References: <20170101031034.GA15639@fujitsu.shahaf.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Error in zshaddhistory() should not prevent command from running MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jan 1, 3:10am, Daniel Shahaf wrote: } Subject: Re: Error in zshaddhistory() should not prevent command from runn } } > Possibly more controversial, why run this hook at all when nothing is } > being added? } } 2) It's easier to call the user-provided hook function on one more case } that it can easily ignore, than not to do so and to leave the user with } no easy alternative. As far as I can tell the only case where *chline == '\0' is when the EOF character has been typed -- there's always at least a newline in there in all other circumstances. There are lots of other places to add to the history on shell exit. But this is why I asked -- other opinions?