From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-40281-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 13041 invoked by alias); 6 Jan 2017 16:02:55 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 40281
Received: (qmail 18822 invoked from network); 6 Jan 2017 16:02:54 -0000
X-Qmail-Scanner-Diagnostics: from mail-vk0-f45.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.213.45):SA:0(-0.0/5.0):. 
 Processed in 1.673355 secs); 06 Jan 2017 16:02:54 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.45 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=QGmkG+8bjwP//e5ZvMZ4nIKrFxct1gWbp+nftyLz2dA=;
        b=NusPtIQH8LUGX+1W/MEIO7XYC7MRfnT8zarTuUeYBmeFdWtZ2yqg1F4hLi/inpP+Qx
         nfWifNtp1yzgqO1UnxnY8DWwlt3KdNWS9kk9judnz26N5sy+4gzBkl9dE0bQ9wIFZPLb
         kZX/9ALT0liBDzHpNPL668j39ho21fV/LhU1Sh6kMwDUnnZ4Q/jk23yCjjsbsilbyQl3
         91syjqZXUa2mWFr86OKZX6iIryD7YGs5TnYC0YayGsZJn+uZQ6HELvnqhIMKMtaHibbx
         9VPmUuztSX2c4zmm+AEx/+qhtxPZYfHfl0WnDTczJYtBREZO1Le83sGXJQINBWoWG74e
         5AOQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=QGmkG+8bjwP//e5ZvMZ4nIKrFxct1gWbp+nftyLz2dA=;
        b=eW288Q/kF4KESC6pm8zGyYSppk1SyxqTgdgWAcWaw4hSxzXIQ9C/SCcsupprAVYMko
         Lo6R7f2KiqJ/j5AnqtXkz46MKK7tRcV5e5tQ5Qf2hkwZFJDyL3tSec7EEuJ0MOTi227D
         rZ/IFfW8yc9+nnFf+jbj6OJjytQlFpP74BuqnHU0TbO74WPE1c8peJbhhK3A2ifXFM3K
         sXOCq618/gjy3jr7FXE1BsVIjWj0PNlupErGl1DQP5U6usqBD0/+9YvA0bjNncNTl8x7
         y6wUpM8qg/lDy+aviPh5Q2NKGruLb4QEIjyFSlqmIyRmYlJEWcWGOTG2HwNwcCzprhm6
         WmMQ==
X-Gm-Message-State: AIkVDXJFCeSijLQNbUc+RQmwE7qM5ttW9mL9thbIk0XZgGYsSX6ai7AjycbfdZg5rDUreQ==
X-Received: by 10.31.11.145 with SMTP id 139mr28518154vkl.141.1483718122831;
        Fri, 06 Jan 2017 07:55:22 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <170106075524.ZM7127@torch.brasslantern.com>
Date: Fri, 6 Jan 2017 07:55:24 -0800
In-Reply-To: <20170105160730.GA21106@fujitsu.shahaf.local2>
Comments: In reply to Daniel Shahaf <d.s@daniel.shahaf.name>
        "Re: vcs_info: '%' in payloads not escaped" (Jan  5,  4:07pm)
References: <20161227150507.GA20351@fujitsu.shahaf.local2> 
	<20170105160730.GA21106@fujitsu.shahaf.local2>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: vcs_info: '%' in payloads not escaped
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jan 5,  4:07pm, Daniel Shahaf wrote:
}
} How about the following?
} 
} [[[
} @@ -131,12 +131,14 @@ VCS_INFO_git_handle_patches () {
}          else
}              git_applied_s=""
}          fi
} +        git_applied_s=${git_applied_s//'%'/%%}
}      else
}          git_applied_s=${hook_com[applied-string]}
}      fi

Shouldn't that + go above the "else"?  No point in substituting on
git_applied_s when it has just been set to "" ?

With respect to the rest of the thread between you and Frank, I
understand Frank's concern but I think you have it right.