From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16546 invoked by alias); 8 Jan 2017 01:14:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40301 Received: (qmail 15418 invoked from network); 8 Jan 2017 01:14:07 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f176.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.176):SA:0(-1.1/5.0):. Processed in 0.950266 secs); 08 Jan 2017 01:14:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.176 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=GMySgluI8SNxicE0F5msXCPCSDK4EZCiUUYs6e0zj0o=; b=o5C5nM3zC4HXYdV5NWBOiEO6+vRs40SIrRZKGn+iO7pZtulBLhk8i6qIzk1FWGfXeV xOSUuqA2Xv9JS+YMPbn3paE6SK5qguFkzlsSW0D2ff8G4M3+JQ/oIfRyOlQzGHwupKrm Q5zEkvVZF1wYPto9LwWbkg/zoxnBE6f/Q5aLYusoNTpDnR9egh1Fid29cm1Hj1jmhyfY R4ZnB4Qah0YYPzMXhmSfdB1Hn6PKugE9bmvMTWxPSf/3VTd93O5PTxoTAVHvGX/DoGdc zWW73dySjGeVKu7POubQqcOVX+XIF7bksahgZo+UFEOZep7M+K/jeI9fwWuPe+rAc2M7 Nu9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=GMySgluI8SNxicE0F5msXCPCSDK4EZCiUUYs6e0zj0o=; b=K6MQuh1cgy4aq44I1d9EGSzbziJH8jb1JkqQsVdXHbZlmlZiDdqIpteanYK9q8EvhR Q5wi6IxmMzwcvmcux98Ks/7jsaRU4Bn4MAptqSN/DchLhlhScN+yxsrvJrFQpaKhG4ci r2DWbOXrU+LHyFKWFg5CFtnHuMFfgwKf03WSk7mW+YMvSgo6YyZ8CSHHe8zuG2jdgqK5 u1LG5ew5K8Ek9RiSXOjEkKS7X0+u67moypB2JafB4eH+/cFvbA5MBhN3FUbTVJiBvEbI V0xSV/LWRZpEOyNRoskXkiovpsO2eX1UJwWvDml4x0K20cBrqPRsHi+yPs9IVbrwgwPj L4rQ== X-Gm-Message-State: AIkVDXIrvrUgiTf+DUS/5+t0rnHfaKMk2YLGJt9mWfHgX4Vh20GYS2RH07g9y62UvFAjsg== X-Received: by 10.176.75.149 with SMTP id v21mr6231022uaf.94.1483724103654; Fri, 06 Jan 2017 09:35:03 -0800 (PST) From: Bart Schaefer Message-Id: <170106093506.ZM7618@torch.brasslantern.com> Date: Fri, 6 Jan 2017 09:35:06 -0800 In-Reply-To: <20170106172541.GA14113@fujitsu.shahaf.local2> Comments: In reply to m0viefreak "[PATCH] isearch: do not use PAT_STATIC since we call zle hooks" (Jan 6, 5:25pm) References: <20170106172541.GA14113@fujitsu.shahaf.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: m0viefreak , zsh-workers@zsh.org Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jan 6, 5:25pm, m0viefreak wrote: } } Using PAT_STATIC, any of the functions called in the hook that make } use of patterns, implicitly change the pattern we use in the } isearch loop. In the best case this results in pattern-not-found, } in the worst case we get a dump. Thanks for catching this. I expect we're going to be findind this kind of thing elsewhere, now that we have so many hook points -- lots of code that was written expecting it would never be re-entered is potentially going to be invoked from hooks, possibly even from hooks within hooks.