From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6333 invoked by alias); 2 Feb 2017 00:56:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40483 Received: (qmail 4546 invoked from network); 2 Feb 2017 00:56:48 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(0.5/5.0):. Processed in 1.447741 secs); 02 Feb 2017 00:56:48 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=QkPK=ZP=brasslantern.com=schaefer@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at bounces.park01.gkg.net does not designate permitted sender hosts) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=brasslantern-com.20150623.gappssmtp.com X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=fmAcjFcsTQCXeQjeCFeRiHRXBWNAHdzc0X0rkTjWjO0=; b=G8P/RhQw9eHA6NABr/CAw5TDlonoWmHaDfgA7Krw57woUf7mAuY70Y+uCmhlwRAJWH mz4rosQZQhShuqjpKHnHUdcWiP3MUfdt4NBqaduFQGQK8Z+pLfmBR8mVGRKDIZUEQbyx 5joaEFo1l2mOq6pTolLAYDgw8i5rEAH8pKdumtOUTGE8p4iRMV/jYG/xkrhROTZxpwRS jWIs7LQLNPxujT6Sl/bQeJgAUbq5Irp6WzbmTjHiV2xYIUO/Cj3pJVZGzpC6W69oUcu9 T9qq18xTJTGjQuQ5DtEJCZi9FL8AO5K38vmPGsJYEQs8ezyRjIkguqakYXpc+mJ+hxcE wSzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=fmAcjFcsTQCXeQjeCFeRiHRXBWNAHdzc0X0rkTjWjO0=; b=kufTm1A8GJgQoOSOjl/Y3Cmt/uXicEqdUita8FYu12aOAQznpihaB9meyutzFD6UTv 4zQiH752zWrLmlKmrvqSQWGPN6b2aaQNZze5KYYHRVawR0crH/uwNJVYOWih9yD6WV0y O7aECewArrbrNSCUUtCijhWPfD8YiFNPlKQYNL4S1KwxxxWlC9FAhn+scQm9a3PTFvcT 1IXUIyj34RVEf3tyKw4Ll6Vj/vW9ldV3mOVqUWf+42XV1OILFOYMQzN8nQfxAbNl2aq6 EvdRbc+8pruYTUaCa1OU+TQe6OQY5C5W3QGOdFxHqWhrNw0WInp6OeBLZrtmoxoU0vCN IUjA== X-Gm-Message-State: AIkVDXLp+Nu0OwMGQF0IdUTW0y5pXe7H/onEhxdDzFhXlTdEqFP8EadcFTACbeygZffT6A== X-Received: by 10.31.125.76 with SMTP id y73mr2886851vkc.5.1485996975114; Wed, 01 Feb 2017 16:56:15 -0800 (PST) From: Bart Schaefer Message-Id: <170201165613.ZM2163@torch.brasslantern.com> Date: Wed, 1 Feb 2017 16:56:13 -0800 In-Reply-To: <20170201204114.53246-1-ericdfreese@gmail.com> Comments: In reply to Eric Freese "[PATCH] Remove zpty exit hook from forked processes" (Feb 1, 1:41pm) References: <20170201204114.53246-1-ericdfreese@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Eric Freese , zsh-workers@zsh.org Subject: Re: [PATCH] Remove zpty exit hook from forked processes MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Feb 1, 1:41pm, Eric Freese wrote: } } diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c If the only meaningful diff is this one ... } + deletehookfunc("exit", ptyhook); } clearjobtab(0); ... then there is no reason to move around all those static functions. Just mark the one to be declared in the autogenerated header file. diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c index 2c87be1..3c1bef5 100644 --- a/Src/Modules/zpty.c +++ b/Src/Modules/zpty.c @@ -331,6 +331,7 @@ newptycmd(char *nam, char *pname, char **args, int echo, int nblock) /* This code copied from the clone module, except for getting * * the descriptor from get_pty() and duplicating it to 0/1/2. */ + deletehookfunc("exit", ptyhook); clearjobtab(0); ppid = getppid(); mypid = getpid(); @@ -852,6 +853,7 @@ bin_zpty(char *nam, char **args, Options ops, UNUSED(int func)) } } +/**/ static int ptyhook(UNUSED(Hookdef d), UNUSED(void *dummy)) {