From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16369 invoked by alias); 23 Feb 2017 21:40:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40624 Received: (qmail 11075 invoked from network); 23 Feb 2017 21:40:22 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(0.5/5.0):. Processed in 0.660505 secs); 23 Feb 2017 21:40:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=mlKv=2E=brasslantern.com=schaefer@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at bounces.park01.gkg.net does not designate permitted sender hosts) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=brasslantern-com.20150623.gappssmtp.com X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=HxOQsxfQhtx9VVXDnHC7cwCh4NImcRZyKuo4rQ4sroI=; b=gmUnyhh/PG/8lQPRp/lTE3Gt2MGQzxRmZf58KpzUihgw8Dr4DJGZx5oF+n02iOQomm NyB3e3i5Z+xxbcwNhEOndZiHTvxL+C+xqzFZXBguR8yfW6IPUaf/3NTLIuqI/34FPRFG VM7s7nKcdf9bbg0iVWbkhoVOuNE4WsnT9XHx9hahkLcxF9QnYACGUBaxewsZJKkddo3q r2/wGXKk686F9iGISq1lf2zmCkDZlDAKcyNX5HKEbQi1b+OdXTA77jS2KfCb47itpf8h cFHdXEzI8La2o7zk7NC26flq6gO8di3pQPgpYawjGiCWvLPIRQCOwRWfSg9kzFPK1ych U7+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=HxOQsxfQhtx9VVXDnHC7cwCh4NImcRZyKuo4rQ4sroI=; b=DHk+U38ODfROTNvadEu6MdRw6vIJW0cIWWaaVL+zDRqBghAUAjVQOlyCsoTQaURfXe ohtKOloHxriNh0vpcck0526KszRy0AGKpnsgxL9urx7fXBCOxBc9u5mQaI3oZttG768y hKa7D67mdGpKPv46H7eCC2VyGqrmvXKRVC/x5LkGNjnVCOxegQbU2qWFxd89xcu9q1DE 5aKHqWSK+PCMLbH3hjLq7Iu5IsHLOl5jPlNqDxcZZTvQnsR+0U9hoqBGZqtBH5cr5Kto zNoI3fPNqIMoB8eGfdzBXpwm5GROqrvvu4Sy13yNyXqsSo4HrVwNYnK4bx5iObJFzb0i R+yA== X-Gm-Message-State: AMke39lAvHYW3A0oX1ooA6hVobfnCKP71Qc9Jw3joWEfOLaoskeoNs4ZcRWX5ZT8GpTAGQ== X-Received: by 10.176.65.133 with SMTP id 5mr8647339uap.149.1487885990208; Thu, 23 Feb 2017 13:39:50 -0800 (PST) From: Bart Schaefer Message-Id: <170223133954.ZM22691@torch.brasslantern.com> Date: Thu, 23 Feb 2017 13:39:53 -0800 In-Reply-To: <20170216201807.GA3274@lorien.comfychair.org> Comments: In reply to Danek Duvall "Re: signal mask bug?" (Feb 16, 12:18pm) References: <20170215221757.GA24355@lorien.comfychair.org> <170215201044.ZM15764@torch.brasslantern.com> <20170216094836.7db14518@pwslap01u.europe.root.pri> <20170216201807.GA3274@lorien.comfychair.org> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: signal mask bug? MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Feb 16, 12:18pm, Danek Duvall wrote: } } So my colleague did some digging and found that the process is marked with } WCONTFLG, and that once that happens, you have to check WIFCONTINUED() } before anything else, because WCONTFLG overwrites all the bits. Thanks. Slight variation on the patch: diff --git a/Src/signals.c b/Src/signals.c index a717677..68a7ae3 100644 --- a/Src/signals.c +++ b/Src/signals.c @@ -522,6 +522,11 @@ wait_for_processes(void) #if defined(HAVE_WAIT3) && defined(HAVE_GETRUSAGE) struct timezone dummy_tz; gettimeofday(&pn->endtime, &dummy_tz); +#ifdef WIFCONTINUED + if (WIFCONTINUED(status)) + pn->status = SP_RUNNING; + else +#endif pn->status = status; pn->ti = ru; #else There might be an argument for checking whether the status is already SP_RUNNING but the above should cover the case of a stopped job that is sent a SIGCONT from "elsewhere" (i.e., not via fg or bg from the controlling shell).