From: Bart Schaefer <schaefer@brasslantern.com>
To: Sebastian Gniazdowski <psprint3@fastmail.com>, zsh-workers@zsh.org
Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
Date: Mon, 27 Feb 2017 08:42:20 -0800 [thread overview]
Message-ID: <170227084220.ZM2518@torch.brasslantern.com> (raw)
In-Reply-To: <1488188512.996718.893937368.139819AB@webmail.messagingengine.com>
On Feb 27, 1:41am, Sebastian Gniazdowski wrote:
} Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
}
} On 26 February 2017 at 20:42, Bart Schaefer <schaefer@brasslantern.com>
} wrote:
} > I suspect this is what comes of some attempt to optimize assignments.
}
} It's impossible, hashes weren't optimized.
Sorry, didn't mean to imply it was the *recent* attempts.
} BTW options+=( ), etc. still segfaults.
I am not able to reproduce that. The functions+= test in V06paramter
passes for me. Also BEFORE my patch valgrind would report errors:
torch% options+=()
torch% options+=()
==2255== Invalid read of size 4
==2255== at 0x80FF148: setpmoptions (parameter.c:949)
==2255== by 0x80C06BA: arrhashsetfn (params.c:3638)
==2255== by 0x80BDAB2: setarrvalue (params.c:2668)
==2255== by 0x80BF2FA: assignaparam (params.c:3133)
==2255== by 0x807C542: addvars (exec.c:2498)
==2255== by 0x807D92E: execcmd_exec (exec.c:3004)
==2255== by 0x807AED8: execpline2 (exec.c:1872)
==2255== by 0x8079D42: execpline (exec.c:1602)
==2255== by 0x8079367: execlist (exec.c:1360)
==2255== by 0x8078B75: execode (exec.c:1141)
==2255== by 0x809819D: loop (init.c:208)
==2255== by 0x809BB75: zsh_main (init.c:1692)
==2255== Address 0x29283D is not stack'd, malloc'd or (recently) free'd
But subsequent to the patch:
schaefer[1031] valgrind Src/zsh -f
==8816== Memcheck, a memory error detector.
==8816== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al.
==8816== Using LibVEX rev 1575, a library for dynamic binary translation.
==8816== Copyright (C) 2004-2005, and GNU GPL'd, by OpenWorks LLP.
==8816== Using valgrind-3.1.1, a dynamic binary instrumentation framework.
==8816== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al.
==8816== For more details, rerun with: -v
==8816==
torch% print $options
off on off off off off off off off on off on off off off off off on off off off
on on off off off off on off off off off off off off off off off off off on off
off on off off off on on on on off off off on off off on off off on off off on
off on off off on off on off off off on off off off on off off on off off off
off off off off off on off on off off on off off off off off off off on off off
off off on off off off on off on off off on off off off off on on on off on off
on on on on off off off off on on off off on off off off off off on off off on
off off on on off off off off off on off off off off on on off on off off on
off off on off on off off off off off off off off on on off on off off off
torch% options+=()
torch% options+=()
torch%
==8816==
==8816== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 24 from 2)
==8816== malloc/free: in use at exit: 0 bytes in 0 blocks.
==8816== malloc/free: 0 allocs, 0 frees, 0 bytes allocated.
==8816== For counts of detected errors, rerun with: -v
==8816== All heap blocks were freed -- no leaks are possible.
next prev parent reply other threads:[~2017-02-27 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 9:41 Sebastian Gniazdowski
2017-02-27 16:42 ` Bart Schaefer [this message]
2017-02-27 18:48 ` Sebastian Gniazdowski
2017-02-27 20:08 ` Daniel Shahaf
2017-02-27 20:38 ` Frank Terbeck
-- strict thread matches above, loose matches on Subject: below --
2017-02-26 0:04 Bart Schaefer
2017-02-26 6:16 ` Daniel Shahaf
2017-02-26 19:42 ` Bart Schaefer
2017-02-27 9:31 ` Sebastian Gniazdowski
2017-02-28 7:45 ` Daniel Shahaf
2017-02-28 16:38 ` Bart Schaefer
2017-02-28 17:03 ` Daniel Shahaf
2017-02-28 19:04 ` Bart Schaefer
2017-02-28 21:51 ` Daniel Shahaf
2017-03-01 15:55 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170227084220.ZM2518@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=psprint3@fastmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).