From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17173 invoked by alias); 27 Feb 2017 16:42:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40658 Received: (qmail 17398 invoked from network); 27 Feb 2017 16:42:40 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(0.5/5.0):. Processed in 1.779242 secs); 27 Feb 2017 16:42:40 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=LfY+=2I=brasslantern.com=schaefer@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at bounces.park01.gkg.net does not designate permitted sender hosts) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=brasslantern-com.20150623.gappssmtp.com X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=5AULPcIOnPiRUsCwhTQ33382tnSYJ8V2WglZ59sW8HU=; b=qAM7S1sT4woYfoI3pzMCqmUAr47ytfh1eW8emHr2L8r6oJfaKuTNkESMAsZVaZ4jso LJkqGilByWERTWPFP31PKuObIRZof1503oxwr1leS/aRGOch43NMDzi0nDNzvw17n24x pebF4WRngpM3e4rxGSm632lP5JxahDBJBSq01DZpGFC8jXpO4Tizc/cpI03wB8vkdDqy N3Mqu9qGRxKFxGk0wTdgZMpjF5/gJNvMzcCtQjUikHdc/L6mkHf+McRgIvf6Y5vJhve/ D1gOBvzAoRKHnur4WdWqUdrDKtMdAIp61/YmF1IhN7NvJ8d04OXeqZePG797ZMqQCFqZ xGIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=5AULPcIOnPiRUsCwhTQ33382tnSYJ8V2WglZ59sW8HU=; b=Nl+KHtMZ0i7/rMNMVVfzRw7y3reDCeyJ7BGcJh90bhc6NcUtSZTNEXUx0aWcwDQ85d VebdGVLqrfyh5vTOkbXqp8/YMBsmNTM+h7NG1M0mFeNzIDeYD82YO2ff0K1d1IkYo6FR 4gpYZT6+22YFU6wzeUEBjLdL8sVO48KyQgdlcBt8NTIUB0lqgPLquFW6zV6Vx5mkraH9 3SIBzHt5erJR6qvU5PAjfTlIrwEph4YFLovv6GBwH6XpCLtVDSLV5nV3ws+TdT04zxtq vE0ayWjNVNKPsMy1eEus0T3yP3h9YL54WAIBx7pQCGVd5Zjp1zHafAvnRlCrijYBF1zY ywWw== X-Gm-Message-State: AMke39knfoZKiAMqnFVKmpF70FIJajbLhguXhCA0hBDxh6IPd84ANBpN0fWQnsJ3uA8oow== X-Received: by 10.176.4.163 with SMTP id 32mr6830144uaw.33.1488213729787; Mon, 27 Feb 2017 08:42:09 -0800 (PST) From: Bart Schaefer Message-Id: <170227084220.ZM2518@torch.brasslantern.com> Date: Mon, 27 Feb 2017 08:42:20 -0800 In-Reply-To: <1488188512.996718.893937368.139819AB@webmail.messagingengine.com> Comments: In reply to Sebastian Gniazdowski "Re: workers/40626 (commit 6c476c22) causes multiple test failures" (Feb 27, 1:41am) References: <1488188512.996718.893937368.139819AB@webmail.messagingengine.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Sebastian Gniazdowski , zsh-workers@zsh.org Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Feb 27, 1:41am, Sebastian Gniazdowski wrote: } Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures } } On 26 February 2017 at 20:42, Bart Schaefer } wrote: } > I suspect this is what comes of some attempt to optimize assignments. } } It's impossible, hashes weren't optimized. Sorry, didn't mean to imply it was the *recent* attempts. } BTW options+=( ), etc. still segfaults. I am not able to reproduce that. The functions+= test in V06paramter passes for me. Also BEFORE my patch valgrind would report errors: torch% options+=() torch% options+=() ==2255== Invalid read of size 4 ==2255== at 0x80FF148: setpmoptions (parameter.c:949) ==2255== by 0x80C06BA: arrhashsetfn (params.c:3638) ==2255== by 0x80BDAB2: setarrvalue (params.c:2668) ==2255== by 0x80BF2FA: assignaparam (params.c:3133) ==2255== by 0x807C542: addvars (exec.c:2498) ==2255== by 0x807D92E: execcmd_exec (exec.c:3004) ==2255== by 0x807AED8: execpline2 (exec.c:1872) ==2255== by 0x8079D42: execpline (exec.c:1602) ==2255== by 0x8079367: execlist (exec.c:1360) ==2255== by 0x8078B75: execode (exec.c:1141) ==2255== by 0x809819D: loop (init.c:208) ==2255== by 0x809BB75: zsh_main (init.c:1692) ==2255== Address 0x29283D is not stack'd, malloc'd or (recently) free'd But subsequent to the patch: schaefer[1031] valgrind Src/zsh -f ==8816== Memcheck, a memory error detector. ==8816== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al. ==8816== Using LibVEX rev 1575, a library for dynamic binary translation. ==8816== Copyright (C) 2004-2005, and GNU GPL'd, by OpenWorks LLP. ==8816== Using valgrind-3.1.1, a dynamic binary instrumentation framework. ==8816== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al. ==8816== For more details, rerun with: -v ==8816== torch% print $options off on off off off off off off off on off on off off off off off on off off off on on off off off off on off off off off off off off off off off off off on off off on off off off on on on on off off off on off off on off off on off off on off on off off on off on off off off on off off off on off off on off off off off off off off off on off on off off on off off off off off off off on off off off off on off off off on off on off off on off off off off on on on off on off on on on on off off off off on on off off on off off off off off on off off on off off on on off off off off off on off off off off on on off on off off on off off on off on off off off off off off off off on on off on off off off torch% options+=() torch% options+=() torch% ==8816== ==8816== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 24 from 2) ==8816== malloc/free: in use at exit: 0 bytes in 0 blocks. ==8816== malloc/free: 0 allocs, 0 frees, 0 bytes allocated. ==8816== For counts of detected errors, rerun with: -v ==8816== All heap blocks were freed -- no leaks are possible.