zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
Date: Tue, 28 Feb 2017 08:38:55 -0800	[thread overview]
Message-ID: <170228083855.ZM7434@torch.brasslantern.com> (raw)
In-Reply-To: <20170228074549.GA8753@fujitsu.shahaf.local2>

On Feb 28,  7:45am, Daniel Shahaf wrote:
} Subject: Re: workers/40626 (commit 6c476c22) causes multiple test failures
}
} Bart Schaefer wrote on Sun, Feb 26, 2017 at 11:42:16 -0800:
} > I suspect this is what comes of some attempt to optimize assignments.

It occurs to me that $options et al. predate the += syntax, so this may
just have been overlooked when adding array-append.

} For future reference, James (who reported the original bug offlist) has
} since reported another symptom:
} 
} % autoload -Uz compinit; compinit; setopt listambiguous; options+=()

So here's my question ... why would you ever attempt to append to the
options parameter, empty append or otherwise?  The options hash always
contains all possible valid keys; you can't add/delete a key; you can't
duplicate a key; so it absolutely never makes sense to append options.

I was half of a mind to flat out make it an error, as these are ...

torch% options[bogus]=on      
zsh: no such option: bogus
torch% options[shwordsplit]=
zsh: invalid value: 

... until I realized that all the other zsh/parameter hashes had the
same problem and some of them *could* sensibly be appended.


  reply	other threads:[~2017-02-28 16:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26  0:04 Bart Schaefer
2017-02-26  6:16 ` Daniel Shahaf
2017-02-26 19:42   ` Bart Schaefer
2017-02-27  9:31     ` Sebastian Gniazdowski
2017-02-28  7:45     ` Daniel Shahaf
2017-02-28 16:38       ` Bart Schaefer [this message]
2017-02-28 17:03         ` Daniel Shahaf
2017-02-28 19:04           ` Bart Schaefer
2017-02-28 21:51             ` Daniel Shahaf
2017-03-01 15:55               ` Bart Schaefer
2017-02-27  9:41 Sebastian Gniazdowski
2017-02-27 16:42 ` Bart Schaefer
2017-02-27 18:48   ` Sebastian Gniazdowski
2017-02-27 20:08     ` Daniel Shahaf
2017-02-27 20:38       ` Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170228083855.ZM7434@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).