zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Ko Stoffelen <k.stoffelen@cs.ru.nl>, zsh-workers@zsh.org
Subject: Re: [BUG] _dmidecode and _adb completion
Date: Thu, 16 Mar 2017 13:48:33 -0700	[thread overview]
Message-ID: <170316134833.ZM17872@torch.brasslantern.com> (raw)
In-Reply-To: <20170316104328.GA4496@fujitsu.shahaf.local2>

On Mar 16, 10:43am, Daniel Shahaf wrote:
} Subject: Re: [BUG] _dmidecode and _adb completion
}
} Ko Stoffelen wrote on Thu, Mar 16, 2017 at 10:21:29 +0100:
} > Second, I noticed that by simply typing "adb " and pressing tab, adb is
} > already executed and the daemon starts running if it did not before.
} 
} I agree but I don't know how to fix this.

Completion/Unix/Command/_adb does this:

  adb ${=ADB_DEVICE_SPECIFICATION} shell exit 2>/dev/null || {
      # early bail-out until a single valid device/emulator is specified and up-and-running
      _message -r "No (started) device specified, completions do not yet work"
      ...


So as presently written you can't complete adb commands/options until
you have a running daemon against which to validate the device.

I don't have adb installed so I don't know what happens if you skip this
step (edit _adb to stick a ":" command in front of that line so it will
always succeed, for example).  If it's possible to sensibly proceed in
the absence of the daemon, then we could make the above test conditional
on a zstyle.


      reply	other threads:[~2017-03-16 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16  9:21 Ko Stoffelen
2017-03-16 10:43 ` Daniel Shahaf
2017-03-16 20:48   ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170316134833.ZM17872@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=k.stoffelen@cs.ru.nl \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).