From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11458 invoked by alias); 9 Apr 2017 18:47:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40946 Received: (qmail 27685 invoked from network); 9 Apr 2017 18:47:00 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f169.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.169):SA:0(0.5/5.0):. Processed in 1.187281 secs); 09 Apr 2017 18:47:00 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.169 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=jPbipeOs4AO252o+Qrd3u7ZpVboP+V7KjCJNMAUcUb0=; b=tw+DjdpC2qCDZOX5Aup9tAWKfR+8LwZqpiNOVBlZQYOk6/zDjTN/cLyVMEPEGGLVhY UG2F8g44xssRcsiNmMPBhufSECbBrb2/fn/Rb+iqy1QG+EohcqT84ftn7vCsOauaJ/3W hL5TFN0Ch8/VoI4yd25amHnGzOWH8V7vw+MGGDcS9Qwc1PKMsnxYrRoBO4OudL8gfqXv RCmL9B74mO1AEtg9gzpebO0a6zPJIDhayBfH5xEN7YtEvUPSnXYAi5PXn1nEdNmVdvI1 ydEdnVEztkpH3nxrr5UsXW5QjMyC3u4/6l/Wiz80XvA+Z8CqD0Be6EpHQ2b4vNTNmOTd sBXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=jPbipeOs4AO252o+Qrd3u7ZpVboP+V7KjCJNMAUcUb0=; b=j/WzRFI+HLVn1zcS+8wOCvAad4rMGjFwRQ+AZBERoZFAD87BN8t8giEFwaFtGcDyAR cTl3COqLotkOxYu+lctSwlSNSXPtSb1Tj9gnXiUJGf9nPdAldX+wuQiqK2KKq5LoevHu hJ612PGR/5nNfMVY8GuNlQkGGnCi2rx7rWOIlW8tXSepo92SKbQmsMYOMc+7UulEAipM HOi5V5gIVBs4bNYYUXbJLDrgufQg2aqn5VYpvPRVZYSgl+TO9V1hwWRO7Kg2WCxkLXvz yGJIDjNS3b7Vs362sUNv8MwPT1+xM6vIFbK2r9cLqOpamkyqaR5/LXOz28QZga7g+InK GI+w== X-Gm-Message-State: AFeK/H0nEoJOGx8XEaYOWI5sn+wFh0xaWsf3daX2WJ6FZ/pnw4lbPvnMxsewtbNdx5S8+g== X-Received: by 10.159.54.202 with SMTP id p68mr21075525uap.51.1491763611499; Sun, 09 Apr 2017 11:46:51 -0700 (PDT) From: Bart Schaefer Message-Id: <170409114707.ZM29561@torch.brasslantern.com> Date: Sun, 9 Apr 2017 11:47:07 -0700 In-Reply-To: <20170409152335.20372-1-genml+zsh-workers@thequod.de> Comments: In reply to Daniel Hahler "[PATCH] __git_recent_commits: prefer recent commit objects" (Apr 9, 5:23pm) References: <20170409152335.20372-1-genml+zsh-workers@thequod.de> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] __git_recent_commits: prefer recent commit objects MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Apr 9, 5:23pm, Daniel Hahler wrote: } } RFC: Daniel Shahaf mentioned that `expl=()` might not be right here after all, } so I am waiting for feedback before pushing it. expl isn't used by _describe so there's no reason to reset it both before and after that call, and it's local to __git_recent_commits so there's also no reason to reset it before the first time it's passed to _wanted. I'm not certain whether it's necessary to reset it between _wanted calls, though it typically will have been assigned a value by the first one.