From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10820 invoked by alias); 7 Feb 2014 14:49:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32361 Received: (qmail 7537 invoked from network); 7 Feb 2014 14:49:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s1024; t=1391784238; bh=jl0fsRx3wRebwDBNr/cfyHUcE6gAf1GBHL2qJKdZdWI=; h=Received:Received:Received:DKIM-Signature:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Received:In-reply-to:From:References:To:Subject:MIME-Version:Content-Type:Content-ID:Date:Message-ID; b=xXv3mKCxxFe3F6SZcm7JZXFHB+B/SW8LNbNiezjnEa7xdi7IJB1Mo8KfnXU4lOMWOhU5ncMwQCebAYx2esRbTDmZIzmc32/jvv/OIU1rIxzTNtarIhXJaaVbOcVSD+l7jtau+PklsgVlTqBwrPu6ZWw6pkE8C9K3Ih1loGA1gYM= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.co.uk; b=yBNKj8lkuIZ31MjdlFkcKur7hapw1eoRjj28///7YBixt94+qBzOOdLbx2ssNp8dKHVoyty91WBRVqwFOVDMX2tUY7ynPQlfEBAfXDrrj2x5+7KACaxjrhSIR0mu0QALnDX+IyF0m+GrQ0JE36aIKLgUhdwyfw7SK2YzsFS5Jz4=; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s1024; t=1391784238; bh=jl0fsRx3wRebwDBNr/cfyHUcE6gAf1GBHL2qJKdZdWI=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Received:In-reply-to:From:References:To:Subject:MIME-Version:Content-Type:Content-ID:Date:Message-ID; b=t9p9Mt+k+MY56tTI27rW31F/BvxqHufi1gP3dc7TukLjRwWhTNAS+nNMQKtRDRjGeL4xnt+5OnD3sTSLFOL5CQLjJtpynFLUYXbJkwQKVVHXjwJYh2gOib5IRcjbmfYApyo7xMBFybSrpQT2sc//jLjCrOsxYe1aJg4O/+P+7aQ= X-Yahoo-Newman-Id: 288829.95378.bm@smtp147.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: NdhUNHoVM1lQ55QGx2HTvt2Gr23SeiJEueCPhqNbwpa7We6 EBjREGla0MKPPgL6se37zHS_qD6Nn3QUNmtuLgnQLjR0KK73DKvY9qNWJsCK o8_YFyBIws9JcSZ8dvjuYOnuQwrsKveG90JxqurNcle_P_MYHdgB3Y5oysn_ EdqPRfAuh8KzJFyygy8dkTWZSiWYxLFxNIWGa_PHSW.cg3uDbiZyxWHgGh8H XetswCke_0wPN_s4BbGT_o.035Oq2cvn9sbcHofh8SSqnsPfqLpF9ZQ7IV7G Fg_vV.eB4ZmbJb5Z0zryt93Up0_3JfgvNa.w_F0lyHsojw51wmntUtr1k.Sd sOJsJGL.nBLWuVizVVKu4dlJQFxf7wALdGS8Lg48jaA6wnpyNOJUijOh3aI5 LLzGqWTWDNtiP6hk7PIpn4QadRqyn660bkmx54E1n23_GcMCAFS4cZuRoi53 A2SlZeufx_.yZOXMPjUtgKJ9vKdT0XgO1zAx5lKhU0KS13SnJaL_vZpmiKSb W5kubblW6bHXpiLLLkkFBA3lO7Q-- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- X-Rocket-Received: from kiddle.eu (okiddle@5.146.58.100 with plain [188.125.69.59]) by smtp147.mail.ir2.yahoo.com with SMTP; 07 Feb 2014 14:43:58 +0000 UTC In-reply-to: <2700.1390950035@thecus.kiddle.eu> From: Oliver Kiddle References: <20130923213014.15f97f9e@pws-pc.ntlworld.com> <3511.1390605547@thecus.kiddle.eu> <140125111530.ZM21792@torch.brasslantern.com> <20140127124301.4144f2d9@pwslap01u.europe.root.pri> <20140127161124.2aa16b37@pwslap01u.europe.root.pri> <2700.1390950035@thecus.kiddle.eu> To: zsh-workers@zsh.org Subject: Re: zle: vi mode: wrong undo handling on fresh lines MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17036.1391784147.1@thecus.kiddle.eu> Date: Fri, 07 Feb 2014 15:43:56 +0100 Message-ID: <17050.1391784236@thecus.kiddle.eu> On 29 Jan, I wrote: > +++ b/Src/Zle/zle_tricky.c > @@ -611,8 +611,7 @@ docomplete(int lst) > - if (undoing) > - setlastline(); > + setlastline(); I have a widget that adds text to LBUFFER and invokes completion. The text added to LBUFFER can't be undone with this change and with emacs mode, the problem was there before. I think this line should just be removed as it doesn't make much sense anyway. It was added in workers/8590 (a reply to 8574). Removing it doesn't seem to cause problems that I can find though the examples in 8574 seem broken in other ways. Oliver diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c index a12fa08..3c7cff9 100644 --- a/Src/Zle/zle_tricky.c +++ b/Src/Zle/zle_tricky.c @@ -611,7 +611,6 @@ docomplete(int lst) active = 1; comprecursive = 0; makecommaspecial(0); - setlastline(); /* From the C-code's point of view, we can only use compctl as a default * type of completion. Load it if it hasn't been loaded already and