From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13356 invoked by alias); 17 May 2017 18:18:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41118 Received: (qmail 18939 invoked from network); 17 May 2017 18:18:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f179.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.179):SA:0(0.5/5.0):. Processed in 1.103822 secs); 17 May 2017 18:18:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.179 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=GrEZPTG/10BlgbXAKjU8RG3EJpNbkQ8iSiBaQeMAKwE=; b=RP4MOqrXJ++HiJNMtVEif0hkpqRQPso08T/jYAIaf2eSj/XKoy0Zyefzb6yxsrTbHa FvcBMUiR87JlVgLlm12JtYo4cOzX1cvZi3nFEfhW34dgQ7TwbCs4bGZtg7JjvC8J/2e9 48+VoRmsKRDUk69SBX56BIIwiD3x5Zfn22IA2VuhBXfxiaQhUI5ZfQT1Ui9DXsgM40nT kurpH2CmRR87dKrXtwfMsD261ep07MXROAEwW0FmYW6lC6kW5TNjK9KCjfPZHATyUt+b XQfjOAxo1T175jskiWvMEX4USSCX+aRjlxaiLCucmr4Eqa2rCIL38v2cQxoEUU44p4N8 S7vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=GrEZPTG/10BlgbXAKjU8RG3EJpNbkQ8iSiBaQeMAKwE=; b=XesPg5ZDVW0gdUmEU1JKf3fiaepCKSMTT/fPJOLF04DZUO65bDVnUgyn/49VfmrDps 9OEh/wdAs1Gsv13NpnZ5qLnLzN/csTQq9TRwNShhoIsoXj+jaPQTnY9o6nHS3bjKAXgD 8iYVBXMq582cX8ZUoUv6bmKI2OcE61xdVYb744Lcr9NjcQv6I0/zg87vYmjieh+Ty93V 22Mv+WMOZ4Q3xLXZNMV1kfbkfdIq1kivOlyKKIrdm0asXE7xdvMlgeYIAvFkagpI1tPl Jl4641ktnNqyXNzfQxPGG+HA1MQGUqBd68qJyLUIv+f2T7+uFWYWwt3JiRJ2Wg4ZM9/G rpMg== X-Gm-Message-State: AODbwcBMgN6QfipFBN1pAa0/cRHNWnNv1b1DjzF3tkH0lzvzThRM5QI+ v9TYl4qdgD+9mxW5egM= X-Received: by 10.176.70.69 with SMTP id z5mr46806uab.37.1495045087458; Wed, 17 May 2017 11:18:07 -0700 (PDT) From: Bart Schaefer Message-Id: <170517111836.ZM27176@torch.brasslantern.com> Date: Wed, 17 May 2017 11:18:36 -0700 In-Reply-To: <20170516120527.572a5cc9@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: zsh 5.3.1 crashes on completion" (May 16, 12:05pm) References: <170511141903.ZM13639@torch.brasslantern.com> <20170512161603.GA16688@fujitsu.shahaf.local2> <783A691B-B69F-4673-B237-B316CEF26346@remrain.com> <170513112313.ZM14712@torch.brasslantern.com> <20170515102819.39284ef6@pwslap01u.europe.root.pri> <170515133354.ZM20191@torch.brasslantern.com> <20170516104831.14aa23c6@pwslap01u.europe.root.pri> <20170516120527.572a5cc9@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: zsh 5.3.1 crashes on completion MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On May 16, 12:05pm, Peter Stephenson wrote: } } cmdsp = hs->csp; } + unlinkcurline(); } + curline_linked = hs->curline_linked; } + if (curline_linked) } + linkcurline(); } } Shouldn't that be unlinkcurline(); if (hs->curline_linked) linkcurline(); ?? unlinkcurline() will set curline_linked = 0 and linkcurline() will set it back to 1 again? Don't set curline_linked before linking it? } + DPUTS(chline != NULL, "chline set at start of history"); Actual error is that chline NOT set at start? Otherwise looks OK to me.