From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28878 invoked by alias); 20 May 2017 17:07:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41129 Received: (qmail 8226 invoked from network); 20 May 2017 17:07:39 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f180.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.180):SA:0(0.5/5.0):. Processed in 1.37462 secs); 20 May 2017 17:07:39 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.180 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=0qLtor171QbUcwW7KCRKjUoE+YZFd/tgp/YuQ+WI224=; b=dYxkglxHKecAn+T1A3fxsWaJEhWyWeZdarKlIrXd5ac/Cp1ZyN9W5l8dZtHrNRoN9M EUjx0eUdkU/XG9BXIad7TtJbpaHrwJklO9j240N3RL13O19ei8G+E89po3tlybN891Kr u6pT6vplgZlVzM5xvH68LrUZ7zTYuuL3/r3nJ1+c4ilnxbMzCogphln0uPMzktHIQ0Ch ObqxuG2qYV8+qTp4nvk4SjXALTCYDRsycki89sjHsyuD4H4OqNqB/06BFsPoEV+GR4HM L4eoiRStkOpjZ7xYXP8bDqhIg9kdEEt4GKf9N0USfYPnDAiaoeJHLeoNFL5VqPRsX6CJ X09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=0qLtor171QbUcwW7KCRKjUoE+YZFd/tgp/YuQ+WI224=; b=jzRZtcXl16l6D6X0DPhQ2qZ7a01RiNkvtRiCa7z26iA09Nr8aiWaOU2JQOKWu75FJ2 EJGtfwgFWN8lEogZJmkgjHRYAT4+pGUlZJ8zKqj/9fpZxvVP+TZT/XaI7qGcEsDl5FlH j9jKIXP/+QCOnUgrQUWcB19XQDG7BLwLOjRphusygF87+4VY6gGoWMB0mbPnKZrr3+KQ 9eFcnNhCZ4BzuopyEcW+Eq4STveH6ECngYfhTXgq615VKm0nHxuLCaGOitclUNYF9wOt fO4LpYh4d3L7BXZUFPdGY11QpESC5POLc6ZnFl1CruSs46PwImibjiekNTPf2awim0rR CpWg== X-Gm-Message-State: AODbwcBVSBRxwvhr2vwQpsk3Giw4ITVwF7N2uiAMD22AbDa8n+HVf7Mt KTZPRat78aF+FPCJE9U= X-Received: by 10.159.57.235 with SMTP id p43mr7587609uag.19.1495300049012; Sat, 20 May 2017 10:07:29 -0700 (PDT) From: Bart Schaefer Message-Id: <170520100802.ZM5161@torch.brasslantern.com> Date: Sat, 20 May 2017 10:08:01 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Re: A patch with hashtable optimization, which doesn't work" (May 20, 7:06am) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Improving zcompdump (Re: A patch with hashtable optimization, which doesn't work) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On May 20, 7:06am, Sebastian Gniazdowski wrote: } } There are no performance gains from keeping the collision list sorted. Yes, I was going to reply to your earlier message to remark that I would only expect sorting the collision list to *slow down* insertion ops, not speed up lookups. } Tried to optimize mkautofn, to speed up sourcing zcompdump. How much does zcompdump actually help? Have you compared startup with and without it? There's a bunch of stuff in .zcompdump. Have you investigated whether certain parts of it are slower than others? One lesson learned with Completion/Base/Utility/_store_cache is that parsing array assignments is expensive. _store_cache now writes out the array contents as a here-document and splits with ${(Q)${(z)...}} to avoid parser overhead. The _comps array is large; maybe there is a big win to be had by changing the format of the file.