From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27891 invoked by alias); 31 May 2017 05:47:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41183 Received: (qmail 15755 invoked from network); 31 May 2017 05:47:22 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f182.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.182):SA:0(0.5/5.0):. Processed in 1.180482 secs); 31 May 2017 05:47:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.182 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=B53uOoufa0v4ynQcnIrIvzhAKZtJAqQtyuWWZDpKvqA=; b=XeRimjAYbWkbvtNmOnQao5aEK7arw0acHB3BB7M06AQAhTJKzwHivODoG+xIl42mdB PDRyRz9bRHCPw+iXXoT+NGLt+LRj140t0i/QgUx3DkoJfUTAKo1MOEdFNsELggvcRnaX dk3woWoI8gclYRMAEm3B8JSZfRIW8Nr/pf/8hh+1rvHYKM2BCVUid75HzQmBZ/nwIWe+ xqCrfav9BGT6mQxO+wfvcIPO2PtMSV1Ah3gHeaRtrWNNpjdNGveAChJBYSyVBh+YeKRA j/3+BVaFZe+wjELLWGySx/MyOf5K5Zz8xA2RZP0enUxPsgWF2RVJh7OxAumVC8/B0KQg c4Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=B53uOoufa0v4ynQcnIrIvzhAKZtJAqQtyuWWZDpKvqA=; b=l+cRnu2CxXkdRWw62Aqnn+zVYmYASeBYC8YxvxayDWdkdncMm1SFtgIOBjaCM5J1t6 /05TJ31RsYmSFQX2S8MUO1xrwAt+QbgnuxcyUkYXrcqNyW3aNCUlQ4rOoEqjEb5G7RQ5 kwZQI7qSrlyQrbXDJ8Cxuev7pJ3+LV0NUQwHQq2XcIEYz79bPYmY1ug1jiStDQ+285Wn DicFm4LgjgmBZdCmN7wYr2+dsxBmaUGINzvEKp6eYqYZB3MyNdvKD2xbdfsBQjbBgVu5 DKSMkswN1GvMggCO8osY0CQAnbSQLjOB+RU97WItUY5lYJhnTaiYICUzY12bJGDETch7 RlVg== X-Gm-Message-State: AODbwcB4XU/f0WcXONk9TEhhUqKRWPMkfNTTFdY5wXkFRd2eKl/zYNjS AbtnktaocQT6Jq5cQp0= X-Received: by 10.176.0.22 with SMTP id 22mr12578816uai.97.1496209634565; Tue, 30 May 2017 22:47:14 -0700 (PDT) From: Bart Schaefer Message-Id: <170530224728.ZM25709@torch.brasslantern.com> Date: Tue, 30 May 2017 22:47:28 -0700 In-Reply-To: Comments: In reply to Mikael Magnusson "Re: mikachu/badarrays (Re: Valgrind testing, ideas)" (May 29, 3:21pm) References: <170528124337.ZM9444@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh workers Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On May 29, 3:21pm, Mikael Magnusson wrote: } } Well, it never worked in the first place, that's why i put "bad" in } the name. It's basically just a documentation of the places I found } that would need to be updated to use a cached length value, but since } it doesn't work I guess I didn't find all of them, or I misunderstood } some parts of the code that I changed... It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN, the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do double duty as they won't apply to arrays and functions at once. With respect to "it doesn't work" -- in commits f4ab07b4 and b7c2ddf6 you say you're adding typeset -C and typeset -c to control PM_CACHELEN and PM_CHECKLEN but looking at the diffs you only added the argument parsing; I can't find anywhere that PM_CACHELEN or PM_CHECKLEN are ever assigned to the parameter flags? I believe I've now merged params.c ... I tried forcing both of the new flags on for non-special PM_ARRAY params in createparam(), and all tests seem to pass except those involving the $match array, which implies one of us did something wrong in setarrvalue() for post_assignment_length. I think. -- Barton E. Schaefer