From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12680 invoked by alias); 1 Jun 2017 21:38:03 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41196 Received: (qmail 5970 invoked from network); 1 Jun 2017 21:38:03 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.175):SA:0(-2.3/5.0):. Processed in 2.301506 secs); 01 Jun 2017 21:38:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_SORBS_SPAM,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.175 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=g+tzxRDvkOuVNj7suRdJ9L8i4agEJoc3nbVwhIwz12U=; b=AWAti7fwO3OdEpHHE5qDBQkvIhWzpYxzIybtXM4+1E05TrPcKXzpZvrT8c+y+do2cx YhnkkGcAURsGTb4zWu4G09PwWKEEpM8Q//iMMamVbnuGnD9C0CTb/COyDWEHTEX+Mtlw MzeQB36j77d+frKFUGsn8QyzP2qH/qhcE13iL3dn6EebVrVIUQrZJEyGOsb8jOUuVsDo N/2OFyguBF1+ZbehzwrVmUJrIviDC1F4+iRGaGlaoQLPSsxF4wE0WBYBsGgXdMMjj3H3 cl4EehoyjQRp+V9ahFaJbHfJzhBlo2jYziiyvOoaJHUd4aUZI/Mey8Gx9JbHCdGTlGW/ 1Hig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=g+tzxRDvkOuVNj7suRdJ9L8i4agEJoc3nbVwhIwz12U=; b=Es0vdx9cSx1xiK1F+TUYq3GWlvPlVwcozZb4skGuJQ+KTCc78zyv/+NiV4wdbBIRLL MJ8MCJbSzIkOQz6VRPX5MBpQRl0/Jms1yVRxkpFdLBVdNlQNnKTTy72h8rI7+6Q6LPjS GhOfJ0o9Y9Hb2GWUYBJxkGaSGhNSQJzpQPELIuH0XjSsWX306OjJxmzua4aWz29wEVue H0bBsmh51f5AL+QouehsxWFSnxqMac0rncgbxqJosSM9WPZMhZSTh/ojXZsLqx4Plawe sdr/rXhuku+RY0PExbW5tWFD21iojgEml3n6qszAnMpAZyY3ZYA8UqlP30UtGIXLdO4F 6SqA== X-Gm-Message-State: AODbwcDTxjq9mOOw30Msg+dUhdyDTqLYvsZyQwuB5FpAhDDdmG6EbU3n UthtBIRZHq8QnLRVdM0= X-Received: by 10.159.53.111 with SMTP id o102mr1970217uao.113.1496353070894; Thu, 01 Jun 2017 14:37:50 -0700 (PDT) From: Bart Schaefer Message-Id: <170601143808.ZM1815@torch.brasslantern.com> Date: Thu, 1 Jun 2017 14:38:08 -0700 In-Reply-To: Comments: In reply to Mikael Magnusson "Re: mikachu/badarrays (Re: Valgrind testing, ideas)" (Jun 1, 11:22pm) References: <170528124337.ZM9444@torch.brasslantern.com> <170530224728.ZM25709@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh workers Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 1, 11:22pm, Mikael Magnusson wrote: } Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas) } } On Wed, May 31, 2017 at 7:47 AM, Bart Schaefer } wrote: } > It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN, } > the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID } > and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do } > double duty as they won't apply to arrays and functions at once. } } The existing code probably does something fun like assigning these } flags based on the order of flags in the TYPESET_OPTSTR define. Indeed, that's the case. So that means it's now essentially impossible to add any more options to typeset, because bit positions 19+ are used by values that must be assigned in the IPDEF(...) structs for params used/set by the shell. In other words adding "cC" at the end of the TYPEST_OPTSTR is now going to be broken by other things, unless we add some special-case code. } If you don't use typeset -c/-C for anything, then none of the new code } should be activated and it is indeed expected that things would work. As I mentioned: } > I tried forcing both of the new } > flags on for non-special PM_ARRAY params in createparam() So they were getting used everywhere, even without "typeset -c". What remained broken after that was the code that resizes an existing array.