From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18511 invoked by alias); 3 Jun 2017 17:08:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41205 Received: (qmail 28035 invoked from network); 3 Jun 2017 17:08:56 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk0-f44.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.44):SA:0(-2.8/5.0):. Processed in 1.580711 secs); 03 Jun 2017 17:08:56 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.44 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=5grjxUxoV2g5vys96lpsDgK0lIsyJzXQXPmwP6G+Ydk=; b=zHr8RYYFwVh6X7yMswMULdNnASUFjL+eh6yt32JorJGe7w5hhsAq3ruiAsOE3yNjEM 2lywzt0sGBZGtG9aSr4Jp24ya8ITE/b/YUQZSRAkTJteHD85DByHv2nOSmcZBrW6bOHZ 021F4reyROXGZKebYfY7esaRuq6UDJ7TXGUeSCWEiR1X1827WwRcrTfaS8HQ0sjvr7tg OOWjBHi9E3cIN2LpnojbXDIVvoATsDNfKRIQF4iLGAw5q8iXv7E4Gq6lPjbpp3eP3lsu us9CYe+UMDfX/nHkXUXUjUkIZFsLMq6qwfMrE15Yf3IEdtOuGCf5/i6QDOcXyETU4Etp 5/4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=5grjxUxoV2g5vys96lpsDgK0lIsyJzXQXPmwP6G+Ydk=; b=Dr2oT8WQ+YgNyhmXjUunuwPZNXUiaV7/o61Bc0eTCvBUNjj2ZftpkERSZAGgZJlQ2J Zyv4gfKDWxx3tpMzGEGkyiRGrx++32T6m4LXZ0O2ZC0C5J0GyQzxz32wvNtUA40QMraO mCO8uPrRBvXTCg+EAxN+qjipg5wSx6HcNRqynP/+8l/gPlnQhxdsJzdrqiDqwuJA4Qyo 8OXSqMnicwHb2nTZBqtvQ3J9srENZdWLm+8jkLQ/FMj52r97afLI/Ks/htc9mq2mVQrq 5gSZ62YQbB7YfqKNLCDatsYJk9eLNxRj/HmxNGx57byImAasqxf0gDjibim7M0NNAUcd W1Jg== X-Gm-Message-State: AODbwcBUU0orO4zsMklCUD0vlV2VIn8ZJARyRGZhA/zX7TNvPJ1Nc5w8 OFePy+PB59ycU4IsXWs= X-Received: by 10.31.11.203 with SMTP id 194mr6193913vkl.12.1496509727799; Sat, 03 Jun 2017 10:08:47 -0700 (PDT) From: Bart Schaefer Message-Id: <170603100908.ZM13230@torch.brasslantern.com> Date: Sat, 3 Jun 2017 10:09:08 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Add redis-db module to upstream?" (Jun 3, 5:24am) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: Add redis-db module to upstream? MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I have no objection to including this module's functionality in the base distribution. However, I don't think we should just chuck it in there exactly as-is. Primarily, we should first decide where this should live in the module hierarchy, i.e., what name should it have? For example would it be appropriate to put it under zsh/db/redis and finally do the work of abstracting ztie out of db_gdbm? (I know this supports some operations that the base ztie interface does not.) In that vein, this also introduces a question of whether zsh/db/ needs to generically support a password mechanism. I'd suggest that it use a parameter, possibly a hash with PM_HIDEVAL set whose keys are chosen from arguments of ztie, but that's just a first reaction and probably needs more thought. Unlike the naming decision, this doesn't need to be determined before the module is otherwise integrated. There are probably a few other design questions of this sort that will arise in due course.