From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13708 invoked by alias); 5 Jun 2017 04:00:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41225 Received: (qmail 4495 invoked from network); 5 Jun 2017 04:00:08 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f173.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.173):SA:0(0.5/5.0):. Processed in 1.057412 secs); 05 Jun 2017 04:00:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.173 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=09SfEwhJtlxZJethCdzunqkbwJwjYDLwl0md3lj3lh0=; b=cDCYKa2mqugi+IDkCqbFmyCEGy+9Z39MFrn0oYsBbgCs3BsPGKWsJFhsX1GHiiTbZd AULqllIgAdmXvYEx44Bpo5ShIoHIUhoLLmHLi0bGNOKREiswvJL0kEPdX9BCbD8OEaTM Yar82+DvhXC41t61EBWA3IKkpCAJ+L8gJeugnKdNDuc+6ItYQ65n2REpbr8EwvmtDIC+ L0exEE2qSOanZFByH0YQgb/h1YykBt0BN4kytGhzG57R4uO/0wxL20zIVn/aZUhXcGQV jwGT1p1takE5M9shr637iSB8/Ntq0Vn9LEfAn9czysCmBnIW6SDosIumstDe/kNXIg8p cfiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=09SfEwhJtlxZJethCdzunqkbwJwjYDLwl0md3lj3lh0=; b=ZlzU0+5ZDLSwG+i5kS0Jdi22hx7DWBDW4Qyv6IHk9YKDgBk/XyMpGshXEfEs3HJY4f uWtxiWRZDCrSgLioHnJ2T6O1DcIrilzCzBkqjEIEx9OuqCek9M0wgvfQMxKD4Bvysp0i fkUS1R50WbllSzakttNO2jjDMHFWJ+8VEjiCn3GIqzJt5dFaMVY8oLwa0hTmCuuqhLTX r4oYN57MvZqYxQ1GIKMIDEyZeYNM882usnpogijnONWo2kOmqd6Trutm4s4F8/6+rAX8 +qCWC1leWm9k/6cHl6MY5VA+ahCObl0ChsXHCcJR2OBwa0cwWX4MoA59UQzVRLZEZ8oc fyOw== X-Gm-Message-State: AODbwcBzy0B6no1c+c53Irc/UGmgnxslHuCROaj5TRoQUreJzPr67GBS ZCbIB/DAVXMIItf3T+A= X-Received: by 10.176.71.220 with SMTP id w28mr8554816uac.3.1496635200044; Sun, 04 Jun 2017 21:00:00 -0700 (PDT) From: Bart Schaefer Message-Id: <170604210022.ZM29965@torch.brasslantern.com> Date: Sun, 4 Jun 2017 21:00:22 -0700 In-Reply-To: Comments: In reply to Bart Schaefer "Re: segfault" (Jun 3, 11:38pm) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: "zsh-workers@zsh.org" Subject: Re: segfault MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 3, 11:38pm, Bart Schaefer wrote: } } All you need is ${(AA)1=} which tries to interpret the } positional parameter $1 as a hash table. Any obvious problems with the following? Other than that t = "1" so it ends up looking like a line number in the error message -- but I'm not sure what to do with that without changing the error message format for other parameters. diff --git a/Src/params.c b/Src/params.c index d92dd22..6fbee88 100644 --- a/Src/params.c +++ b/Src/params.c @@ -3242,12 +3242,17 @@ sethparam(char *s, char **val) if (!(v = fetchvalue(&vbuf, &s, 1, SCANPM_ASSIGNING))) { createparam(t, PM_HASHED); checkcreate = 1; - } else if (!(PM_TYPE(v->pm->node.flags) & PM_HASHED) && - !(v->pm->node.flags & PM_SPECIAL)) { - unsetparam(t); - /* no WARNCREATEGLOBAL check here as parameter already existed */ - createparam(t, PM_HASHED); - v = NULL; + } else if (!(PM_TYPE(v->pm->node.flags) & PM_HASHED)) { + if (!(v->pm->node.flags & PM_SPECIAL)) { + unsetparam(t); + /* no WARNCREATEGLOBAL check here as parameter already existed */ + createparam(t, PM_HASHED); + v = NULL; + } else { + zerr("%s: can't change type of a special parameter", t); + unqueue_signals(); + return NULL; + } } if (!v) if (!(v = fetchvalue(&vbuf, &t, 1, SCANPM_ASSIGNING))) {