zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Return value from execstring(), or construct Options for a builtin?
Date: Wed, 7 Jun 2017 09:11:13 -0700	[thread overview]
Message-ID: <170607091113.ZM17152@torch.brasslantern.com> (raw)
In-Reply-To: <etPan.5937d363.6b8b4567.2787@MacMini.local>

On Jun 7, 12:20pm, Sebastian Gniazdowski wrote:
}
} backend_cmd = "zrtie"; // (or "zgtie")
} execstring(backend_cmd, 1, 0, "ztie");

I believe this is very much the wrong way to do this (even though I
suggested it as a solution for a different specific problem).

The right thing would be to handle this the way that ZLE entry points
are managed (see Src/init.c:zleentry), with one module to contain ztie
and related functions which makes an entry point call back to the chosen
backend module.

The decisions about how to abstract bin_ztie et al. from gdbm should be
made by discussion with this group, not by you racing ahead on your own.
Proposed approaches are of course welcome (see for example the discussion
about numeric sorting).

} The problem is execstring() is void return type. Does it store retval
} somewhere?

It's in the global variable "lastval".

} I can also call builtin, have builtintab correctly searched, proper
} HashNode is obtained. But not sure how to fill Options argument.

This is handled by Src/builtin.c:execbuiltin, Options objects are
allocated by the static function new_optarg.  But you should not be
in the position of needing to care about this, you should never be
calling bin_* functions directly.


  reply	other threads:[~2017-06-07 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07 10:20 Sebastian Gniazdowski
2017-06-07 16:11 ` Bart Schaefer [this message]
2017-06-08 10:04   ` Sebastian Gniazdowski
2017-06-08 23:14     ` Bart Schaefer
2017-06-08 23:31       ` Bart Schaefer
2017-06-09  8:53       ` Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170607091113.ZM17152@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).