From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26130 invoked by alias); 17 Jun 2017 03:03:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41311 Received: (qmail 1143 invoked from network); 17 Jun 2017 03:03:25 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk0-f67.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.67):SA:0(-0.0/5.0):. Processed in 1.55214 secs); 17 Jun 2017 03:03:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.67 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=mW19A4HFbT4NaN2g9vvzIJJQHo28zo+7IT3koUiUkac=; b=H3/4rxgtutelKr/6pvY61/IsqewVmXE5xsZEe7ZoGcGBF3C+qAYDy/SHxgetfIFcrI 3l4sX8Jnw0mfT+KlCCVm/U9JdwpJB/8JHHWgjc35uz5SmoOz22UK8CX0k4ijNSzw1SSh e/9YEoCaye8wADxeTm/dXkYKFKItYJsXKcjkVMLg4RU4eN+dyzBxYZAP7efsPHND/mek HR7w6/s/htgClfp54Pf3lDg8fPVjqNdEfwUHqbMBZw2SZHtvhyEWFH1xTTCFlauAbbcM ysMRymCT/m3DE70j54T5pnY7o33HyxjtX0V4/DQWFSivPoijWV0bFxX+uRu8s49UElyQ kdGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=mW19A4HFbT4NaN2g9vvzIJJQHo28zo+7IT3koUiUkac=; b=pRADo0Nw1q4ji1aXQ4OQ6yXkiT3O5HvirHzViLuvFI4WS6be74Hz1GGYTHa383VxWz aN9AhPCNJY08vbCguq0s4OeDXnrxUADpZtNl4VsN4T7kipg7X3cFi2qJ+u6/VYyJOkpr 0N3MM313B9OhczT9QUnzdyZECqS59T7K7K0VNWlnq0d2lhKdTHlIDD1Cq4Wrq8shMfsD 4nFjLl+PXMBQeuZ6gqExaFJmt34jEaN7jofUtAaVpg86lqWWSKnAWY7/cZN4t9HmvRRT 0CBR/jiRUW8wpdwNxbBIgpJULQuH2ZOp+lyRSAoZpf0X9ta3962orEzDQ9xh23ExCaYL WdtA== X-Gm-Message-State: AKS2vOyX1ZrmPj9JHCJQOrHwDYpG/6oOLOgSFDyBqIEjSuIMuHKxeO+u N9HM0/DrqUPMBQLnsAs= X-Received: by 10.31.227.196 with SMTP id a187mr5663936vkh.63.1497668592850; Fri, 16 Jun 2017 20:03:12 -0700 (PDT) From: Bart Schaefer Message-Id: <170616200357.ZM27935@torch.brasslantern.com> Date: Fri, 16 Jun 2017 20:03:57 -0700 In-Reply-To: <20170615084244.GB2416@chaz.gmail.com> Comments: In reply to Stephane Chazelas "Re: [PATCH3] Re: avoid closed stdin() in zle widgets" (Jun 15, 9:42am) References: <20170611182045.GA5318@chaz.gmail.com> <20170612060554.GA4709@chaz.gmail.com> <1497278089.1853864.1006670720.0A8DB74D@webmail.messagingengine.com> <20170612151042.GB3806@chaz.gmail.com> <20170612151902.GA19315@chaz.gmail.com> <1497281675.1868175.1006750384.46FA1223@webmail.messagingengine.com> <20170612190218.GA12445@chaz.gmail.com> <170614154425.ZM20199@torch.brasslantern.com> <20170615084244.GB2416@chaz.gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: "zsh-workers@zsh.org" Subject: Re: [PATCH3] Re: avoid closed stdin() in zle widgets MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 15, 9:42am, Stephane Chazelas wrote: } } In other words, I would certainly not want zsh to refuse to <&- } just like I would not want close(0) in C to fail. } } The case of zle widgets running commands with stdin close was } not a case where the user requested stdin to be closed. So, just being contrarian at this point, if _main_complete were to have done "exec <&-" that would be OK, but because the C code does it we have to patch it. The point being that the completion system does LOTS of things that the user didn't explicitly request, but requested implicitly by choosing to use it. It traps various signals, throws away error output, for some commands even runs "su" or "sudo" -- although the latter are probably the best analogy for this because we added _comp_priv_prefix.