From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes
Date: Fri, 23 Jun 2017 01:36:43 -0700 [thread overview]
Message-ID: <170623013643.ZM7546@torch.brasslantern.com> (raw)
In-Reply-To: <etPan.594b8830.59cfcf4a.63ea@zdharma.org>
On Jun 22, 11:04am, Sebastian Gniazdowski wrote:
}
} 1. New module `zsh/db` that provides good architecture, via
} `*_main_entry` functions in client modules (zsh/db/gdbm in this
} patch).
Nit-pick: This does not include "the following two paragraphs" in any of
the licensing comments that refer to them, so technically it doesn't
pass the license requirements for borrowing from db_gdbm.c.
We might want to update a few of the error strings to make phrasing
and capitalization more similar to others in the shell, but there's
only minimal consistency there anyway so probably not urgent.
Given the bug-fixes in zsh/db/gdbm, this seems worth accepting if the
license comments are fixed. Other opinions?
next prev parent reply other threads:[~2017-06-23 8:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 9:04 Sebastian Gniazdowski
2017-06-22 9:05 ` Sebastian Gniazdowski
2017-06-23 9:29 ` Bart Schaefer
2017-06-23 8:36 ` Bart Schaefer [this message]
2017-06-23 21:30 ` Daniel Shahaf
2017-06-24 3:53 ` Bart Schaefer
2017-06-24 4:56 ` Sebastian Gniazdowski
2017-06-25 0:50 ` Daniel Shahaf
2017-06-26 2:40 ` Sebastian Gniazdowski
2017-06-24 17:36 ` Bart Schaefer
2017-06-25 8:06 ` Sebastian Gniazdowski
2017-06-25 11:22 ` Sebastian Gniazdowski
2017-06-25 22:52 ` Bart Schaefer
2017-06-27 5:46 ` Sebastian Gniazdowski
2017-06-27 8:39 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170623013643.ZM7546@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).