From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12923 invoked by alias); 23 Jun 2017 08:35:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41348 Received: (qmail 23557 invoked from network); 23 Jun 2017 08:35:58 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.217.175):SA:0(-1.0/5.0):. Processed in 1.623749 secs); 23 Jun 2017 08:35:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.175 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=UhHc23/1ko7MNQZnj+CeS7UE3S2zge/Du5X8YFSRvqA=; b=v/t4qSe1VIrqXi3SR+FMdcFj6dNL3Qfi+g2FZkO+rShxdCI+SjMXpdc3bLcpfYbpCG vI6sYK7geJeEts+aks3C/761GD6nC579808QiHi1LHwNUqnpw5tgA1jgoz0QjrWm8w/R fJKQZjUANX+ilv1y+Mr4VfhOj+kAYC7y0SLtwVXTnfdEXvBrtVlS8j3H6MZjd/FjpISy fSiXgw4WS/4WzA7VaqXTQdZIayzewPHUviiYAKX+aBOw9kYSObOVqBxVHFZl7R5k5yvr N8TYlAcc+5fXImsBR17mWOXGGIqx0R6JlJil74aot/1FyxNbV5i5g85jek3WG/msX0pW FwEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=UhHc23/1ko7MNQZnj+CeS7UE3S2zge/Du5X8YFSRvqA=; b=CGTnNZ8f2UNbqrzPstEJuZZKg3NcNI0z1DOkw68CS3sebcG3tA6Zz2tTK0qX1Tb9Oa s/bCnDnl0zHldB+ku865Si7aBpfU+6ZvsWm0zZVQ0WRbc/8ubUZ7lCBOw9/BL9WSnjR4 VdFLDuMp6fyghmlen9QZXf59bgLgleKznc35aihaP6PaLi68RrkHAJWcZN38MIMvs/q5 mq3HYzE6GN6Lg5spodIF7o+0+lc5NJxf2fQlIsy6cXXhnZdFD363lOulnySd5pJH9yhR 8rqsNOPm6v0IDgzOcyvHitf5HEvmQb6LT0/1oIaMyp1XsWJWN8HiYLDk3VHPukhnu62J 7HtQ== X-Gm-Message-State: AKS2vOxiVccxNmTwgoaJsx0HdD6CnbmLdK3iM1mteM0xDZqOG7ZpnQnq ife/GYIW4tuzNwwXEGM= X-Received: by 10.176.17.239 with SMTP id q47mr5357514uac.29.1498206947849; Fri, 23 Jun 2017 01:35:47 -0700 (PDT) From: Bart Schaefer Message-Id: <170623013643.ZM7546@torch.brasslantern.com> Date: Fri, 23 Jun 2017 01:36:43 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "[PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes" (Jun 22, 11:04am) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 22, 11:04am, Sebastian Gniazdowski wrote: } } 1. New module `zsh/db` that provides good architecture, via } `*_main_entry` functions in client modules (zsh/db/gdbm in this } patch). Nit-pick: This does not include "the following two paragraphs" in any of the licensing comments that refer to them, so technically it doesn't pass the license requirements for borrowing from db_gdbm.c. We might want to update a few of the error strings to make phrasing and capitalization more similar to others in the shell, but there's only minimal consistency there anyway so probably not urgent. Given the bug-fixes in zsh/db/gdbm, this seems worth accepting if the license comments are fixed. Other opinions?