zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes
Date: Fri, 23 Jun 2017 02:29:07 -0700	[thread overview]
Message-ID: <170623022907.ZM23851@torch.brasslantern.com> (raw)
In-Reply-To: <etPan.594b8863.185cac83.63ea@zdharma.org>

On Jun 22, 11:05am, Sebastian Gniazdowski wrote:
}
} PS. moddeps in zsh/db/gdbm (.mdd file) seems to not work right.

Hmm.   I had gdbm marked as "static" in config.modules, and after
applying your patch:

srcdir='../../zsh-5.0/Src' CFMOD='../config.modules' \
  /bin/sh ../../zsh-5.0/Src/mkbltnmlst.sh bltinmods.list
ERROR: linked-in module `zsh/db/gdbm' depends on `zsh/db'
make[2]: *** [bltinmods.list] Error 1

So I made them both static and then recompiled, but there is still a
problem; if I don't explicitly load zsh/db first, loading zsh/db/gdbm
crashes.

If I explicitly do "zmodload -d zsh/db/gdbm zsh/db" then the crash is
also avoided.  It appears that mkbltnmlst.sh only creates add_dep()
calls for modules that are loaded into the shell by default (load=yes
in config.modules).  This only matters if there is a boot_ dependency
rather than merely a builtins dependency, so e.g. it doesn't break for
zsh/zftp and zsh/net/tcp.


  reply	other threads:[~2017-06-23  9:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22  9:04 Sebastian Gniazdowski
2017-06-22  9:05 ` Sebastian Gniazdowski
2017-06-23  9:29   ` Bart Schaefer [this message]
2017-06-23  8:36 ` Bart Schaefer
2017-06-23 21:30   ` Daniel Shahaf
2017-06-24  3:53     ` Bart Schaefer
2017-06-24  4:56       ` Sebastian Gniazdowski
2017-06-25  0:50         ` Daniel Shahaf
2017-06-26  2:40           ` Sebastian Gniazdowski
2017-06-24 17:36       ` Bart Schaefer
2017-06-25  8:06   ` Sebastian Gniazdowski
2017-06-25 11:22     ` Sebastian Gniazdowski
2017-06-25 22:52     ` Bart Schaefer
2017-06-27  5:46       ` Sebastian Gniazdowski
2017-06-27  8:39         ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170623022907.ZM23851@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).