From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25706 invoked by alias); 23 Jun 2017 09:28:19 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41349 Received: (qmail 23912 invoked from network); 23 Jun 2017 09:28:19 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk0-f46.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.46):SA:0(0.5/5.0):. Processed in 1.418616 secs); 23 Jun 2017 09:28:19 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID,URI_NOVOWEL autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.46 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=YN6Xv/71KhoLHg+TtUmRQfUfVDJPboHTurypQcrLR6I=; b=HlV83aDW0sMj8O+fijZPkvYMHfGVmO2GQEoOiXliXwms0Y4amOncFluoN6pOa3Xm4J raEKXP8ntY2ZfUjZe5Em7KZB7WCd6OR/6c/5vu8DXB/5QhGXVvhk9DHMjtKj/1vLtNSq f8yoMLaRFpmDESxyV+bFuSzfqMxl85XzMmMNdZE/TaYHKi6MTsOP2u0r0rHWwQoskTnp X88ixpbGk5LHaBEvuglW6vejReoU9mPjnUqw+dLrzOE4QRYUb7QNrTJH/IVeT8r8gh7I SA+FpHkHirBP3dcKKk7yVdsfJ7xBFrh3DYZ1CobNZMalJH9w29r5YMSD+Jg/sb/et5ps 2lfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=YN6Xv/71KhoLHg+TtUmRQfUfVDJPboHTurypQcrLR6I=; b=a5ZS35BQSe3V/+KnTunAZw1zseVH67a/QM15aYDmYCxruB3qonW9JdHrWkHz5m75+F wqarJCsaAA8ZDeFDvH053tHekY0IzHNgNg2ZCvnlcqDt/di/LaxQS8BEs5q8SNlRTY3s +RufMNEZ4411FEjrczFCQQP2Qhla72vRI1WEzTWxGiSpeJDpc0qQCyoJB4h6sy3Ao7V/ S90RHm0NRQIZFL8i/vWuRsu6ni3RLu/7ThqMCpp5sHg8Ba9/N2RbMvqziKIYAFveMzwW FshmcPU6ZM6T3o6G8VA7rnjnr1GMqzbOYOgYW7WZEo/fG1P2mzkeegUOKGu0YX6FUokC zVig== X-Gm-Message-State: AKS2vOz9FYgY1E00f8w8OogPeUZLX6OItVA1C3CSnkjhzc2QOlIJ34MS Q8A7S5vWS6btMS4ZPq8= X-Received: by 10.31.47.211 with SMTP id v202mr2282810vkv.4.1498210090839; Fri, 23 Jun 2017 02:28:10 -0700 (PDT) From: Bart Schaefer Message-Id: <170623022907.ZM23851@torch.brasslantern.com> Date: Fri, 23 Jun 2017 02:29:07 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes" (Jun 22, 11:05am) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 22, 11:05am, Sebastian Gniazdowski wrote: } } PS. moddeps in zsh/db/gdbm (.mdd file) seems to not work right. Hmm. I had gdbm marked as "static" in config.modules, and after applying your patch: srcdir='../../zsh-5.0/Src' CFMOD='../config.modules' \ /bin/sh ../../zsh-5.0/Src/mkbltnmlst.sh bltinmods.list ERROR: linked-in module `zsh/db/gdbm' depends on `zsh/db' make[2]: *** [bltinmods.list] Error 1 So I made them both static and then recompiled, but there is still a problem; if I don't explicitly load zsh/db first, loading zsh/db/gdbm crashes. If I explicitly do "zmodload -d zsh/db/gdbm zsh/db" then the crash is also avoided. It appears that mkbltnmlst.sh only creates add_dep() calls for modules that are loaded into the shell by default (load=yes in config.modules). This only matters if there is a boot_ dependency rather than merely a builtins dependency, so e.g. it doesn't break for zsh/zftp and zsh/net/tcp.