From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14787 invoked by alias); 25 Jun 2017 22:52:43 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41363 Received: (qmail 13105 invoked from network); 25 Jun 2017 22:52:43 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk0-f47.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.47):SA:0(-2.8/5.0):. Processed in 0.938905 secs); 25 Jun 2017 22:52:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.213.47 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=50tQQ2od7iq/Yc8U3J7aaT/BFEIS5pWhPygat3S8d30=; b=hhvIhXbd4Su51yh2gKewdeTqvAVmSsNLZiDomJEAuMLSkeG34a58yI0p68uYRR9+K2 P3wt/LVt0NsispH6v5tcaLqZ8vRr6xeEzt3UJyIDVBX8zIJmAv5WijZ1bHM0nphOWvoL o4C52cXkjV78TKgFbBuNyDycDuUY2BuS2Dx/kK6uV0kflZy+yuIrPhI3CMwklU4T+R5m +5HIijKvk/LvjnEXwLiq7Uyxt6Boe9cd7cID8Oth+rak0dIIjPNxThlb32uL0PrN9Zvz NWy93Rnff/l4H6gNHs2gmYGRwXLU9Q3JWkflyNuEuY46fRljIvqNlNEkTRm9R3ozc5sf SJIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=50tQQ2od7iq/Yc8U3J7aaT/BFEIS5pWhPygat3S8d30=; b=DmS6IavNetGb/r8pUBQ8q4S4kc9G4pX6DkL1lNYeYF2gUhLASvuHZsAjgsRLQU6Sya RFytJqNRlvq2hO+xSxyxdcWqJ6p7AmS6ot1s6tZR/tgNhsrCF/40xjRdkYY5bmDyIsks B5kGASxFYV2g5g/u2NLJ9cD/XrfXqILLgWXYl26ozEExHLeWE5voaYXGm0kDtPvgm/Td p1KpVuzE0yenQMST98XTCc+4s/ekyjK8/KLXQL6YXcRZ1vHMf9exElwgplSeNZiKTze+ G7wP3xIM1KEwiKDCBgrDXt7yTI5CaiL7AE2kRa1uD62l1+BxqFUNeJl853DlzCx/eMWY E7Hw== X-Gm-Message-State: AKS2vOzVXHwtVDUUhuqPQuuEU/o7jmGMrMVd6WycAnZLclZL+6PKfDDH m+KEZ7LZjfkp0wmkhkg= X-Received: by 10.31.54.140 with SMTP id d134mr6944686vka.15.1498431153672; Sun, 25 Jun 2017 15:52:33 -0700 (PDT) From: Bart Schaefer Message-Id: <170625155232.ZM29068@torch.brasslantern.com> Date: Sun, 25 Jun 2017 15:52:32 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes" (Jun 25, 10:06am) References: <170623013643.ZM7546@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 25, 10:06am, Sebastian Gniazdowski wrote: } } As for folding, I attach Emacs screenshot, to show it really helps. } Learned the folds from reading NERDTree source (vim plugin), it was } huge, but had the folds and they helped. Is this really more helpful than selective-display? Ctrl-u 1 Ctrl-x $ Gives you e.g. (copied from builtin.c): /* Print a builtin */ /**/ static void printbuiltinnode(HashNode hn, int printflags) {... } /**/ static void freebuiltinnode(HashNode hn) {... } I find that more useful than a comment with just the function name, and it's easier to avoid redundancy or the comment being out of date with respect to what's inside it, as well. Also if the 4-space indentation has been followed carefully enough, you incrementally unfold by adding 4 to the previous selective-display level, e.g. Ctrl-u 5 Ctrl-x $ /* Print a builtin */ /**/ static void printbuiltinnode(HashNode hn, int printflags) { Builtin bn = (Builtin) hn; if (printflags & PRINT_WHENCE_WORD) {... } if (printflags & PRINT_WHENCE_CSH) {... } if (printflags & PRINT_WHENCE_VERBOSE) {... } /* default is name only */ printf("%s\n", bn->node.nam); }