From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22669 invoked by alias); 11 Oct 2017 03:49:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41858 Received: (qmail 16369 invoked by uid 1010); 11 Oct 2017 03:49:03 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f173.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.173):SA:0(-4.2/5.0):. Processed in 5.198039 secs); 11 Oct 2017 03:49:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_SORBS_SPAM,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=gC+r8t9O6LYZRKVSwLOEIPNWmMe9DzsLxKlJyOSqUQI=; b=d8fN0+XoIxr/RbBheJW+Zl14Fz1GHx3tVAUbINvvheAlHW7sb0uBIe08Icxf6wsVte jMC6Ic5p1a1Cnxwq5hEhAh5ANfwuq0GkXreZSDD7Ci5O6TJivlng0JjSHe0ZtCd2a4VN 8f6sZW23SnV1GlvYA+M2SW27npu5yHQZFBC0dWwmwW4IxqYE3+Zo1Ufbx2VPRfMhkYES JULn/OifJRJ6Eh4igJfMwvul7tt3HKUlcSemYiVB45yGXvdjMcR+WFgDXCziYhrcgcGj VRhbXiL/ZVzPYQlaXqi2ZzCCSaeGATWyrYWg+O6uxTxu5JTkjV2uKNZZ+6fUFz51Mpiq B1dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=gC+r8t9O6LYZRKVSwLOEIPNWmMe9DzsLxKlJyOSqUQI=; b=Vfoa4Xx42GkMH5SSgFe+OOI0+w1yaKnyY/iTLb+jydJU7fvSRLoDZlv/9uIyreEXIe rzBm32WdpWgzF5jEmu1kxyE5ch0uRtgDmZFxfOSmnzj25U8p03/znvZOYYpau0PD3QmH a52DTeBqqQuVQLnxv2JdpIk++ID9vUIUAkg6APeRuSjPL3ojtqQP/25e5M/8VT3qy6px Kvtzg+BFR1CrCh9ifrIDaiToappYW0aQZWit00kqiPxtlA6g47v9mOHtl6fdLLTV+1KO wHeizDnCU0d61FfKPnrwuwuypp3PBsoebg6HjbMvMJpQV8e0xxTefm0iH5JmvLNbigmo Yr+Q== X-Gm-Message-State: AMCzsaVo7GPuRzIzD2s8vfo9RaS/n486faKBhnay8Hg6Wl3cVPgCToEp voCSPDlO0s6+bPk1p+qOKXDOsRQK X-Google-Smtp-Source: AOwi7QBsfhfDpgjf4G30GcuaNZuHqzvVi7n6Zh6xHvAhBI+gXHpMLU3taUSBKmQkFArWLYHP2ix3ZQ== X-Received: by 10.98.100.5 with SMTP id y5mr10322552pfb.161.1507693734580; Tue, 10 Oct 2017 20:48:54 -0700 (PDT) From: Bart Schaefer Message-Id: <171010204917.ZM18524@torch.brasslantern.com> Date: Tue, 10 Oct 2017 20:49:17 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Re: [BUG] In reference to patch 39815, about (z) flag and $( parse error" (Oct 10, 6:19pm) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Sebastian Gniazdowski , zsh-workers@zsh.org Subject: Re: [BUG] In reference to patch 39815, about (z) flag and $( parse error MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Oct 10, 6:19pm, Sebastian Gniazdowski wrote: } Subject: Re: [BUG] In reference to patch 39815, about (z) flag and $( pars } } Following parses correctly with (z): } } asmcmds+=(${(o)$(ls -1 | perl -alne 'echo foo') } }) } dbpkgs+=(${(fo@)$(pacman -Qq)}) } } following doesn't: } } asmcmds+=(${(o)$(ls -1 | perl -alne 'echo foo' } )}) } dbpkgs+=(${(fo@)$(pacman -Qq)}) } } And looking further, it's about ")" being at the same line as $( So the doc says that (Z:n:) "causes unquoted newlines to be treated as ordinary whitespace" but in fact what it really does is cause newline *not* to be converted into a separator; it is still labeled as its own separate token, which confuses this parse. The following fixes it, but it seems a hack -- is there a better way? diff --git a/Src/lex.c b/Src/lex.c index 8493d47..a7b71d6 100644 --- a/Src/lex.c +++ b/Src/lex.c @@ -308,8 +308,14 @@ zshlex(void) isnewlin = 0; else isnewlin = (inbufct) ? -1 : 1; - if (tok == SEMI || (tok == NEWLIN && !(lexflags & LEXFLAGS_NEWLINE))) + if (tok == SEMI) tok = SEPER; + else if (tok == NEWLIN) { + if (lexflags & LEXFLAGS_NEWLINE) + zshlex(); + else + tok = SEPER; + } } /**/