From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1329 invoked by alias); 11 Oct 2017 17:02:12 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41864 Received: (qmail 28936 invoked by uid 1010); 11 Oct 2017 17:02:11 -0000 X-Qmail-Scanner-Diagnostics: from mail-pg0-f52.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.83.52):SA:0(-1.9/5.0):. Processed in 1.885687 secs); 11 Oct 2017 17:02:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=Z8q8llmG0lmKTSPVYgjnqw53tXidte1XzqkA62lO338=; b=yPWtsjwOf3O6Hc20qAtlG+IF5qLT/nFukAMoqUnk/ucg9LIwcGt0Y9+WK8a9tPgIZs MJNe/7oBStL5GgMz34bLU0xS6jo9D0QKh8Vv3rnfvtSbfYHjs5Z+97+FwsH8adTbbuaq 9VuzoqWyhwPRIgV7Um+krdgqBSs9i1C3W6X71+XfWtewSOtE+JjzculKr6qZ/h3w8/8a x2VV4VcZd74tfBJhKTH7Pf914g/T39pFxd9IGRUOJcKq9tgb80VO5xjkEPUd+gyZHIIS Oen4LaOm8E6uW4AHy6r/6ES5fG/e9HcNydBJ4rvJHd0CepN1isiyqpdJDTyoqPg4XGxS qmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=Z8q8llmG0lmKTSPVYgjnqw53tXidte1XzqkA62lO338=; b=V7aKr6VUfU82m81jnMG2A6qheEWpp4RoSxR+6MU3oBXjLLySWlSePLte5BFuA/ShUE N3PiC1kw71nuJ9GK6pnN8NBntNjJMQN+Tu1Czsf00V4s8mo3H2fgRoeUXvNdZnL/ViM4 KU44kQKcjpFreYeTUcVRYXL5XrLyg2yrFR3Qf4OdPajGKdW+NSKqLNCL5TajYgEyL5mj 23KaimDKoxzmYganlJ0+z8/sNuQa5aMKUunYGVYj9vpgq3t3UyWClNV3LSmSxZe435B3 6zMTRiYVEpkoYfLlBUAOMHeZ/JxFIz+aTDwE7So1yMYlDcJXwXW0meS7ek/IZfBg0nEE +k+Q== X-Gm-Message-State: AMCzsaWaEu0Tj3W6Dbr/AGvxSUyYvOlxqlcU38hy7bJWhcL2r1EfleJt zgHf1+juQLc2m4AdSNM6ta5wxNPM X-Google-Smtp-Source: AOwi7QAWqGc8Ax/THnusW2wgTZ10KrKtus+rDHR71QTCNlRXQbgTI6zm6vp2he3zuD+JyeRxDY+YQA== X-Received: by 10.84.210.105 with SMTP id z96mr169634plh.183.1507741326679; Wed, 11 Oct 2017 10:02:06 -0700 (PDT) From: Bart Schaefer Message-Id: <171011100231.ZM3821@torch.brasslantern.com> Date: Wed, 11 Oct 2017 10:02:31 -0700 In-Reply-To: Comments: In reply to Sebastian Gniazdowski "Re: [BUG] In reference to patch 39815, about (z) flag and $( parse error" (Oct 11, 10:31am) References: X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [BUG] In reference to patch 39815, about (z) flag and $( parse error MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Oct 11, 10:31am, Sebastian Gniazdowski wrote: } } However one test fails on this line. Hmm, so the problem appears to be that when parsing a comment, we actually need the NEWLIN token to mark the end of the comment. When parsing code, we need NEWLIN to be ignored as whitespace and not tokenized. That is, in your example the ZSH_AUTOSUGGEST_CLEAR_WIDGETS line is parsed incorrectly (with my patch) because the line preceding it is a comment. So I think the fix for this is going to have to be elsewhere, rather than in zshlex().