From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13848 invoked by alias); 7 Dec 2014 17:43:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33908 Received: (qmail 26140 invoked from network); 7 Dec 2014 17:43:12 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1417973855; bh=p+EW1N2SaN1wgJy4fIKqHXrqnJD2/KWtDmu96JfeeYw=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=SyXQSjpjPnX/SM/6UC2ej/yULH81uIRmWx7RgWfUBMNcb1uEqyHqugDt7KE0vdu42tAeeR6gWW9AEmyNzH9CTkznd/1DcuwiJy0BQCaSKoXaV8Iq2iEcg+ciV7QvAaC7+BQQU4ukkFB1lE7Gr+7caZbAeKo77AO2CvYmWxTW1BNo2AJkOOUY7pRoQuMlGLbVnBmVEP9GJVA7ghEoEcc+AnWoXLP8U8INYaljbopyRWLtXiNr4JysAvBUqEvh0v3SQAq7qkCuw/tNWHLd8QMNfj/AcUhAbJfw7RMXs0/ugCI91qgow7WCGitKfkVG/4eDgdMqr9i+Me3/w/qtF3rS0Q== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.co.uk; b=Ed6X3WcGHvLEgsz5siZ/KOQ6rvlwYpVxgIZGwD/NmjH1dql/5w+DhUcVxpDk97CcpjTBMA+esy08CA2SKq8YF5F7AqK/BiQj0j/ZNW3Un49hiQ9b3+2mL4BKSCsdHsNh0K84OIbXanyPV9rCQUaxHXui2wTSD5OuWaBzhnIa/KrZuaG5tfaE31LweoQPVQ8TWRYK7EjZ1ELoa07CgDowaa5/O9VjX8/ygH2wKwlqlThnPXS4vphnXlOcEfXZ1L1a6vbmiNCtXiJwFOKFUa3EbhEHUhMNV6TLHQs55LcLapOIYn2dZjdi/2BYJA5NjzH5AexKxSiuQ2A36ngxRpgDnA==; X-Yahoo-Newman-Id: 53248.94671.bm@smtp124.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: rzbxyTwVM1m4rHx3mBdIQ6bFg7lPqQr1IyoX_UZYTSZETyP 8JuCczInl54B7q1xzTd.ZWveqSdn7ydWFYvPPJGArI6rG2tdijUEF8tXmuID xunOVzyXqo35vkuTT2QrRTEBacASSMH51HiEy4AUADVmBVv.IwVJF00xGZBS SXNdhYqKOYDTFUpiOUwCuzVQs1B6pDyLQVC.vHP77bL0DtIDp4n93qwnxvdq v9jn1rF79Yenbn9GfS.k9aA5AZEcEBkqA45zBDbh1MXp1H5HESp3mrnPaUxP NvEcKf4mH046qgDbzr7Dwe0HY7vDOJuezkfWZ2vgNkyUkQeK1DMcJN3.Q2yS 7zmMxtrjdf4Yh9UlygAYmjbld5eeLDVmVjG3Y74Ed8iGJY4SFbkIdpnY64dH LB8HSBV6HmSpQ1B0VNDHcGoapcSj9f.Gn_jBpjS4H7hA8jatFLJ0CpW4ooev dZn259ZWDNBzzVs_nMPrc1BFH9S2_hxyvoR.58_jpGExAaqp6Hw4w86B5J2t LxCl7GBX_0EsL4rKrWkHtVvzcsAA- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- In-reply-to: <20141207170713.1a71fe0d@pws-pc.ntlworld.com> From: Oliver Kiddle References: <20141202155452.647182b4@pwslap01u.europe.root.pri> <141202084858.ZM31517@torch.brasslantern.com> <20141202172654.30e7d380@pwslap01u.europe.root.pri> <141204085606.ZM9146@torch.brasslantern.com> <20141204171226.301e9d2c@pwslap01u.europe.root.pri> <141205002023.ZM19736@torch.brasslantern.com> <20141205145054.655a2f70@pwslap01u.europe.root.pri> <141205100632.ZM508@torch.brasslantern.com> <20141205181330.2b458b46@pwslap01u.europe.root.pri> <20141205203417.2bc66b7b@pws-pc.ntlworld.com> <20141205220717.2f86bdd2@pws-pc.ntlworld.com> <141206211828.ZM15934@torch.brasslantern.com> <20141207170713.1a71fe0d@pws-pc.ntlworld.com> To: "Zsh Hackers' List" Subject: Re: Interrupting globs (Re: Something rotten in tar completion) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17350.1417973853.1@thecus.kiddle.eu> Date: Sun, 07 Dec 2014 18:37:33 +0100 Message-ID: <17351.1417973853@thecus.kiddle.eu> Peter wrote: > > It's also just occurred to me I may have introduced some rare but > entirely possible read-modify-write races because we set the ERRFLAG_INT > bit in interrupts and set the other and clear both bits separately in > the main shell. I guess it would be better to queue interrupts whenever > we add or remove a single bit of errflag; that's probably not often > enough to cause efficiency issues since should only be round significant > chunks of shell code, or when an error has actually occurred. Opinions? Could that perhaps be solved by making errflag a volatile sig_atomic_t instead of an int? Oliver