help / color / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: zsh-workers@zsh.org
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>, dana <dana@dana.is>
Subject: Re: sudo autocompletion
Date: Tue, 11 Feb 2020 11:12:21 +0100
Message-ID: <17405-1581415941.062275@CNCV.ghXS.ifR-> (raw)
In-Reply-To: <20200210192033.1bae83dc@tarpaulin.shahaf.local2>

Daniel Shahaf wrote:
> dana wrote on Mon, 10 Feb 2020 11:13 -0600:
> > +  zstyle -e ":completion:${curcontext%:}:*" command-path \
> > +    'reply=( $path ${path/%\/bin//sbin} )'

I don't like it when completion functions set zstyles. I know that the
cache functions do it but even with one bad precedent I think it is
better to not proliferate the practice further. Without testing this,
I'm sceptical that the context will match at the right times - it'll
contain sudo as the command component but that may not persist.

For a solution in _sudo, the environ style is perhaps better because
that is directly where it is looked up.

> As an alternative, _sudo could set _comp_command_path=( $path
> $path/%\/bin//sbin ) and then _command_names could use that value if

We already set _comp_priv_prefix, _command_names could detect that
and adjust a local $path if it is set. That has the added advantage
of keeping the definition of the root PATH in one place rather than
repeated for doas, sudo etc. This is the sort of thing _comp_priv_prefix
was created for.


  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <912d22db-8a8f-90f2-6738-f9f395994dcb@gmail.com>
     [not found] ` <CAN=4vMqvzUTZ7bBLcbTzi-pKAVEP1xDbq=f5pLAxmffxUjTszQ@mail.gmail.com>
     [not found]   ` <1770be62-54d8-70a6-8b05-cfc98faa9b9f@gmail.com>
     [not found]     ` <20200210030219.527a3ccf@tarpaulin.shahaf.local2>
     [not found]       ` <ADE72275-1311-44BE-9B1D-5E617E3D9F94@gmail.com>
2020-02-10 17:13         ` dana
2020-02-10 17:40           ` Peter Stephenson
2020-02-10 18:57             ` dana
2020-02-10 19:20           ` Daniel Shahaf
2020-02-11 10:12             ` Oliver Kiddle [this message]
2020-02-11 10:28               ` Setting/Querying cache-policy (was: Re: sudo autocompletion) Daniel Shahaf
2020-02-12 16:51                 ` dana
2020-02-13  1:21               ` sudo autocompletion dana
2020-02-13  1:29                 ` Bart Schaefer
2020-02-15 22:22                 ` Andrey Butirsky
2020-02-15 22:48                   ` dana
2020-02-10 22:05           ` Andrey Butirsky
2020-02-10 23:02             ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17405-1581415941.062275@CNCV.ghXS.ifR- \
    --to=okiddle@yahoo.co.uk \
    --cc=d.s@daniel.shahaf.name \
    --cc=dana@dana.is \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link


Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git