From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,MALFORMED_FREEMAIL,RCVD_IN_DNSWL_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 0ebdd5c0 for ; Tue, 11 Feb 2020 10:13:14 +0000 (UTC) Received: (qmail 11187 invoked by alias); 11 Feb 2020 10:13:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45416 Received: (qmail 23036 invoked by uid 1010); 11 Feb 2020 10:13:08 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25718. spamassassin: 3.4.2. Clear:RC:0(205.235.26.22):SA:0(-1.0/5.0):. Processed in 3.26518 secs); 11 Feb 2020 10:13:08 -0000 X-Envelope-From: SRS0=RBk9=37=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at bounces.park01.gkg.net designates 205.235.26.22 as permitted sender) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 X-YMail-OSG: CqmcPkcVM1noNH2ra.XjJVTshyr_KoR0OrfB7vG0DmcuhnP0Bd7BWJafVG9L_aX 1QP6rZKKQWxtM2YPDIiVFWZXDvEJCjhiwLw8giVi3noHQpX4ZtSuDpLiitrGxATBUp2dPDBXdvid Ui5.d8wqrOx6gBfu7RoofdcKO3naxoaaFt0Dr6mD7_Ufb3J2IpOoFi3DHxozLVlvvzeCQDW3xsJM hwZDcAjlhUF73jdgOwt.QpziOxRJFEt0LRy_ip5DVff4PzPf4dYWZmMtTbIy1dJP06eoTygPOWDh beclZCteByyHab2muuThTYd4egu1ZFXkABbw66.FB2lEE9LNva1Pqt8Vpax7t3lgKXp0W.afXlft xe2Bx9qOagm.79eI01pGfuF4TxDEZDXnxVvwi8W1VE1ZAprEdfsW_D5uIktRqQrQJ7zSwbUif8A2 jxx_XnbqCoS3eRUkAJyoKroWzuZqkHjUk4rIW3J4uggDBVWYY5fMmSSbjBc.xnBmZxwuP74mcrm5 smkO_YDClnpE3aHlFjt9y.dg71cUOp92gXcsFo9V0UaOhBKYpxlsmn7jNmlE0tnJOZN1haMmyZjV 4jRKygHVSxanTl7103WyXrSBlXV20FWP15.G_XfEANagGYzq17cJLtChiRqAUA4J5YAWQ7MXB_zc cbKDILgsOH9.mJXsuxGnHlgY7lZHQWor4jcu8uCROiDeJqNY3WmuF4sXPg_3Lt33kYsiUULJd_pL 9uhiYC7v1gv36xaBl121tTQ.MDM6NKMfyV4lTLXoWIsGvG00KnzHowh1LMaEkqT6bXwUMdMen90T cB9EQQXYmV8DrMb.JKnAj6lmOHNy2eOwHn6JdOUdxo_BGSiIMecMozUWZRBcqYiZaIkCn9YkXVQC TPvz9ODv023RQwJLUXVr7kRRmQidWcmw__gfNrovUrAL2adc4NBmS0E0hBLDQKelr9Y7vP6vO2mL GiMIt3knJXMOkrBUz5VDrmY28CRs0vNttd.DuraOkRu7RZyhA4lc2B2MMlkomYFl6ZHwCAsYgxSv JIwvQ5WdFUXhYtBnoOSJSlrYQgLYsnSSu8PU0KuqKJApeHo1iFOW0zMYAUVHEjpPnZ350uMgbtMA tVyPuQVlzoqtq7EIfCVWmZj6HTiRojUW.Si4fmt5BNhHsnN.6cHEGyE0W9Ukztj5zryz1mgcNdht 7tRh32AzN701QPpVFkWxgluYR7VVVj4K6mSpPaENuUlLM_e1HvvpO.z9y8vrSZ2DxEQhE6DrX0R7 ogFLzSLOSR4UF3nxKwSZ1gDVwuSZg7aDXK07W4fKgvRSOD8IEkbU86T3AMdOzbpgQxzThFevLhm6 L_VauXEw0obypTKYD77xb8YwsFGJX1z.h4jE9UO6PTnCpkUxQImU0N3WNz0PpDnVVVA24UlO3n2Q Gl5xFUDe_8XX5Zie8uEg- To: zsh-workers@zsh.org In-reply-to: <20200210192033.1bae83dc@tarpaulin.shahaf.local2> From: Oliver Kiddle References: <912d22db-8a8f-90f2-6738-f9f395994dcb@gmail.com> <1770be62-54d8-70a6-8b05-cfc98faa9b9f@gmail.com> <20200210030219.527a3ccf@tarpaulin.shahaf.local2> <20200210192033.1bae83dc@tarpaulin.shahaf.local2> cc: Daniel Shahaf , dana Subject: Re: sudo autocompletion MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17404.1581415941.1@hydra> Date: Tue, 11 Feb 2020 11:12:21 +0100 Message-ID: <17405-1581415941.062275@CNCV.ghXS.ifR-> X-Mailer: WebService/1.1.15199 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) Daniel Shahaf wrote: > dana wrote on Mon, 10 Feb 2020 11:13 -0600: > > + zstyle -e ":completion:${curcontext%:}:*" command-path \ > > + 'reply=( $path ${path/%\/bin//sbin} )' I don't like it when completion functions set zstyles. I know that the cache functions do it but even with one bad precedent I think it is better to not proliferate the practice further. Without testing this, I'm sceptical that the context will match at the right times - it'll contain sudo as the command component but that may not persist. For a solution in _sudo, the environ style is perhaps better because that is directly where it is looked up. > As an alternative, _sudo could set _comp_command_path=( $path > $path/%\/bin//sbin ) and then _command_names could use that value if We already set _comp_priv_prefix, _command_names could detect that and adjust a local $path if it is set. That has the added advantage of keeping the definition of the root PATH in one place rather than repeated for doas, sudo etc. This is the sort of thing _comp_priv_prefix was created for. Oliver