Re: 4.2.0-pre-1

[Peter Stephenson <pws@csr.com>]

Ibraheem Umaru-Mohammed wrote:
> Hmmmn, sigcount.h seems to have unclosed quotes:
> 
> ,---- [ sigcount.h ]
> | #define SIGCOUNT        59
> | #define sigmsg(sig) ((sig) <= SIGCOUNT ? sig_msg[sig] : "unknown signal3)
> `----

Yes, I can believe that's wrong...  Presumably it's also wrong in
signames.c.

The problem must be in signames2.awk which generates this:

    printf "#define sigmsg(sig) ((sig) <= SIGCOUNT ? sig_msg[sig] : %c%s%c)", 34, "unknown signal", 34

My guess is your awk is truncating the input line in some weird way.
(It can't be 80 characters, however, since you wouldn't get the `unknown
signal' at all.)  Can you try altering that line as per the following
patch and see if that helps?

If your awk is playing up, you might find other weirdness, in particular
the `# ifdef USE_SUSPENDED' bit in signames.c.  So even if it looks like
it works it would be worth checking (or posting) the resulting signames.c.
Any fixes ought to be similarly trivial, but I wouldn't like to second
guess what awk is actually getting up to.

Index: Src/signames2.awk
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/signames2.awk,v
retrieving revision 1.1.1.4
diff -u -r1.1.1.4 signames2.awk
--- Src/signames2.awk	15 Feb 2000 16:44:54 -0000	1.1.1.4
+++ Src/signames2.awk	2 Mar 2004 12:05:38 -0000
@@ -63,7 +63,8 @@
     printf "#include %czsh.mdh%c\n", 34, 34
     printf "\n"
     printf "/**/\n"
-    printf "#define sigmsg(sig) ((sig) <= SIGCOUNT ? sig_msg[sig] : %c%s%c)", 34, "unknown signal", 34
+    printf "#define sigmsg(sig) ((sig) <= SIGCOUNT ? sig_msg[sig]"
+    printf " : %c%s%c)", 34, "unknown signal", 34
     printf "\n"
     printf "/**/\n"
     printf "mod_export char *sig_msg[SIGCOUNT+2] = {\n"

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************