From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23862 invoked by alias); 21 Jan 2018 00:03:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42307 Received: (qmail 28072 invoked by uid 1010); 21 Jan 2018 00:03:11 -0000 X-Qmail-Scanner-Diagnostics: from mail-pg0-f45.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.83.45):SA:0(-1.9/5.0):. Processed in 1.182427 secs); 21 Jan 2018 00:03:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject:cc :mime-version; bh=JzAC332jlw/Seoq5OS58vZqjxw/lgQSkpLB1FEkx3tw=; b=tFrFxm/gOA1wuJO1u5MqsmNMCCg9sdZhr8Pajsijb6iWlaVVyciTsyXUuVrPzfdgng dwKLFcYGNvLI6ut9/VGSuwSBvsou1ZYIhjq9Gz0XbxR5I57KCCCU2W/l0O1NWvb0tink /DqUmsaE36RVtq0q/8CUtI3VfIaraAFr4MYbfwgVZR0BNbkwnGiIYaW7Tao/K83eqpKV XDcQ4vROQZdlLkWj0Ji00CLO2MY70U7Em2Xcux1VUQID278p6Wl7kEzvsQJ9NWeKabqv 0U0FHUzKr4cQyy5gicI2C/MfP11wzJr+LesgAOg6LDo8VCHcRFh8TdnbaepOcubFY9U4 pZHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:cc:mime-version; bh=JzAC332jlw/Seoq5OS58vZqjxw/lgQSkpLB1FEkx3tw=; b=tVm29FHwe3cc1xPtRebHCs4s5pTpZrAeK1yMM/zSrsEiq9NkMiv1Y+sFQiuXtlKXq4 uFx93gZLNgq/ieJM+gDOViy/eps91vO7ofNei9TFovHW5aV1FVT+OKZh+rwGZbnla0Ha P4tCEJ6GluidnHqISXDrWWONAxHTUwgQz1Q8ZsLl5Qx7jhD4EOA9RapM3XOea9UCZarV pOOL6lpXcSpROwhBZYLaMd9/cX+1gW5xGC+0lOvLGX83eB9K5d1z0L2K97W7jDunmFiA Ye/0ge0/B9jEdEyZD9Y81QN3dwiR2aBnrjooWVleo/JFiXI9lre2c81q8mcFRGWr1uI8 Q7mg== X-Gm-Message-State: AKwxytd3WXjJYkHqWuydgWdcoyn9eLd0WlK94/iviE4wOOO61/CaSAek QvEYOKmPLJ8mhcRQ6c2Bz6vS32WW X-Google-Smtp-Source: AH8x226FYqe91UTl3UPU7VFN353Tfq/RAoZUsiOPWZez+DnrZTnHAIq5ibmPqZSKEJLMEoy3Y/6mng== X-Received: by 10.101.83.8 with SMTP id m8mr3271039pgq.247.1516492987442; Sat, 20 Jan 2018 16:03:07 -0800 (PST) From: Bart Schaefer Message-Id: <180120160304.ZM12968@torch.brasslantern.com> Date: Sat, 20 Jan 2018 16:03:04 -0800 In-Reply-To: Comments: In reply to Daniel Tameling "Re: [PATCH] jp: fix segfaults during parameter expansion" (Jan 20, 5:16pm) References: <20180114060557.hmrvpg6t4rdebgv6@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] jp: fix segfaults during parameter expansion Cc: Daniel Tameling , Joey Pabalinas MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jan 20, 5:16pm, Daniel Tameling wrote: } } while working through my email backlog, I noticed that my zsh didn't } segfault. I used git bisect, and it looks like commit } 4b8db48c6bd3c0230a5d81f49e478857adf9cda8 introduced it. This is a bit of a red herring -- the fault is actually in the handling of the (P) flag. What this commit changed was the handling of the (A) flag, to make it independent of the ${name=value} syntax. The potential bug in handling of (P) has always been there, but we never attempted to convert the scalar into an array in that context before. My patch in workers/42268 addresses the thing that crashes. However, I think the following may be better: torch% : ${${(PAA)p[foo]}::=x} zsh: parameter name reference used with array diff --git a/Src/subst.c b/Src/subst.c index d027e3d..042ef28 100644 --- a/Src/subst.c +++ b/Src/subst.c @@ -2423,7 +2423,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt, int pf_flags, * substitution. */ if (isarr) { - if (aval[0] && aval[1]) { + if (!aval[0] || (aval[0] && aval[1])) { zerr("parameter name reference used with array"); return NULL; }