From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17736 invoked by alias); 21 Jan 2018 17:57:03 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42311 Received: (qmail 1363 invoked by uid 1010); 21 Jan 2018 17:57:03 -0000 X-Qmail-Scanner-Diagnostics: from mail-pf0-f179.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.192.179):SA:0(-1.9/5.0):. Processed in 3.537393 secs); 21 Jan 2018 17:57:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=HuYiuFTeGJpweGhb87TAMn19evA4NBMfAK4IPRoXOug=; b=Hp/v6SwZVzEqGsvLTPSg4iEX3YHA5QoZgeBtI6XC2hKsP2fc75jRKRJJfiEa6Ab/uL Z+wqWN7Ayzd2g2hj81cOc++pnmgcUOM8UtoXEipD3A577ikHzuFySDctTVQEm/S03WyL gZutrm1f5lw8hszMO5Bx1SNBPuh627nsFvKCjh+rnSwKgB32ZigZh9y1d5xYSdGMx+9T 3FC4xeoixB2PdHiNX80exycyQbvR9lbjUJAnDgrxq9AauelY63Uxd+0We0DXTZ5i1McI mUczjFjPaVaS+fuZ5Omkjw4GReTjTj3bVcFGCT+Hd3britmn3hyy0O8HrUuiExh8Skwk +S3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=HuYiuFTeGJpweGhb87TAMn19evA4NBMfAK4IPRoXOug=; b=sX21/IHJn/6XEpUrIT5oNRtSvt3mi2ih5qK05qUSai9pK2d8OnOkIP6WgHKUNVpnSS vqnjq4C7tfGoBqp/tuEZhyRw4hUwMSxHcnvA7YYW7gG/Osmpze8Ru6ZL0XVD0A4BfhHq iBWK4p2YHOiDVZiQdkHjbZHGN4zz+TkXeWiM91WxmpAVObhmlbpxW03jO2SHKT0l/s7I pRQwqDLPeIIxpPkewS9JJKNn76fZ9n3xPyoSQn/EAL7d8z2cxl8ui1Hg7u1aRs1xkWDR 8eAAyndry58v1GQXy9hR5AwasvhPdCA0oh0YL0IP3WPhUCFE68bhsfMbkY9z9/AHFbQk iOyA== X-Gm-Message-State: AKwxytcg1PqWq/cTGN5jDX0wF9+U+avDesrcAVcK1ud342sDtJEcy7+c 1eyNrG83TB8x2lKzgqUOg67UL21p X-Google-Smtp-Source: AH8x225cI5ag0Bxi3R0Iso0/sECyV3LBdVQybP98ZdqvfmprPuWXCpRJE2JNd0g2qJLGbo0snq3IqA== X-Received: by 2002:a17:902:a610:: with SMTP id u16-v6mr2224639plq.401.1516557416408; Sun, 21 Jan 2018 09:56:56 -0800 (PST) From: Bart Schaefer Message-Id: <180121095654.ZM11776@torch.brasslantern.com> Date: Sun, 21 Jan 2018 09:56:54 -0800 In-Reply-To: <20180114152959.lm4go4ym5fpkvir6@gmail.com> Comments: In reply to Joey Pabalinas "Re: [PATCH 3/3] jp: Add `dupstring()` fallback to `zhtricat()`" (Jan 14, 5:29am) References: <20180114152344.12018-1-joeypabalinas@gmail.com> <20180114152344.12018-4-joeypabalinas@gmail.com> <20180114152959.lm4go4ym5fpkvir6@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH 3/3] jp: Add `dupstring()` fallback to `zhtricat()` MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jan 14, 5:29am, Joey Pabalinas wrote: } } On Sun, Jan 14, 2018 at 05:23:44AM -1000, Joey Pabalinas wrote: } > Add `dupstring()` fallback machanism to guard against NULL derefs } > in 3-argument concat function. } } I am not 100% sure about this patch, so I split it off along with } the error message changes; feel free to drop individual patches or } suggest improvements. I suspect we're not going to include this patch anyway, but in case anyone is trying it out, please not it only catches null pointer in the first two of the three arguments to zshtricat().