From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18894 invoked by alias); 21 Jan 2018 22:43:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42314 Received: (qmail 1618 invoked by uid 1010); 21 Jan 2018 22:43:05 -0000 X-Qmail-Scanner-Diagnostics: from mail-pg0-f47.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.83.47):SA:0(-1.9/5.0):. Processed in 2.416791 secs); 21 Jan 2018 22:43:05 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=iHH9SeHvcTs3p5HfGhV/gigSHhQumvKKlLTJdNL0CyE=; b=whfufXXCkMbQgEdAoVyGGbgqXHV78aKw5aK2WtnPIu4M+HW7uRJxcB3k2NysuWF7/m kV8WnlwKFa3UMT51x4xg4RVwxdBGVvjq9DOppuo8EsLb9tuvHxBreENHwmQYB/e75ROE xToT0hgK/3zw+hCNNHZGisdDEEVneDr1KbCKkb3MlcpSJJ1wWIh9PzIGJfvOvfqbPqEE uaaQY1aZ9Ymdq5JUlOZA8AQEjeRrsR6xpuSFWuvjp5LgLhIqQbpJ1pmM8vcFAa6iw3P6 CZdKXoSH/w5PYleRbAo/vJBXDdlonvPbbTt2hR38h9jbfQ8W2KuuqUDe2SweG5i/4zxs NGag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version; bh=iHH9SeHvcTs3p5HfGhV/gigSHhQumvKKlLTJdNL0CyE=; b=NGN3+d0g/A8BACOBfpVvW9NpBCz6CgzvY6D06U+z4pVbXfUvhJv7A9ZWhqLCM7BYJH QdCo1pMTGa66BEzwHr8Ad8CR4sIDA7wGHjeFSQmPwvdGA2QeDg5QIDGedXOc8cGrIZzc vcks7QhmtVVDeoAcVXHtWjIxD2TYYzX1XYJKiZSmxBbWs0rIv6htz7nb8Nt+up7TKC81 Am479+4CGfEpgXxmHs7aizygHRRz0TbXlquYL16BL/lWP/b6g1jxsyZRI41KU+X/nRoX yCAJdcxhNUQ0OcdcHCb2ebIHU2dlsT9Skt4sS6bUIOKpqxYC8wXOWvoyoYC/zunDgS+4 jiBQ== X-Gm-Message-State: AKwxytepQ5bajZJ3qqlgI+ekztbEYuYjS1bmyWJ+LBFxTTsTK0q2UcBE v8OKGHSgVvrSIycZg5tL/inI/e0n X-Google-Smtp-Source: AH8x226OzkmifA2HK0VvHpAlML8tNSi2QjgbPafS+C+dVOChvBNjR56I1+1MrLLAPlJbOLdfTJqbvg== X-Received: by 10.99.113.67 with SMTP id b3mr1144524pgn.134.1516574579752; Sun, 21 Jan 2018 14:42:59 -0800 (PST) From: Bart Schaefer Message-Id: <180121144256.ZM12835@torch.brasslantern.com> Date: Sun, 21 Jan 2018 14:42:56 -0800 In-Reply-To: <20180121202836.77alwuapsgbwzsbr@gmail.com> Comments: In reply to Joey Pabalinas "Re: [PATCH] jp: fix segfaults during parameter expansion" (Jan 21, 10:28am) References: <20180114060557.hmrvpg6t4rdebgv6@gmail.com> <180120160304.ZM12968@torch.brasslantern.com> <20180121014758.lu7vt7qg4kuup5qd@gmail.com> <180121094326.ZM11602@torch.brasslantern.com> <20180121202836.77alwuapsgbwzsbr@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] jp: fix segfaults during parameter expansion MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jan 21, 10:28am, Joey Pabalinas wrote: } } When i send updated patches, what's the best format? A new email after } a separate response mail, or as a single email with the response } at the bottom (or some other third option, maybe)? Typically replying below/inline with an edited excerpt of the message is preferred (as I believe you have been doing) rather than top-posting. Also generally one explains the patch first and puts the patch at the bottom, rather than having the patch in the middle of the text, although there can be common-sense exceptions if there's something about the code that's easier to explain after it has been seen. It's not necessary to go back to the start of the thread to respond separately/directly to that. Better if the patch comes at the end of the discussion context that brought it about.