From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15435 invoked by alias); 6 Jan 2018 06:43:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42239 Received: (qmail 16821 invoked by uid 1010); 6 Jan 2018 06:43:33 -0000 X-Qmail-Scanner-Diagnostics: from mail-it0-f53.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.214.53):SA:0(-2.6/5.0):. Processed in 1.415846 secs); 06 Jan 2018 06:43:33 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=HGY8EtWSbvalPN/NJYlL83ezJYxbqwC1stlclvRCd58=; b=vj/v521I1REIBGd3McqGw/NalgsUIMd3VzF5Q96jemIcVO6cXHC6a1q/Lz+FAMvB0g t/errK4NRCDvUeI/U1bWgT1Nj3UzZ8Sfvo5N2ZEWdq4FbIraHqd2xv2f8haQMrfVnlAy kVcxKdkaWYjTHW6AFJSYRTcNHrWWJeBjx5KuXo1dEJZuOflPYip+SltU+QuQ8mBmRamR fisUKhEaTHyAHVqoHqI/JhpdqKYd1fUGVptivJk+XTrxvJysFTnVE6tDKfF526Kxj1hx 4CpQV+cq0JHN/deAAgzbEpcd8ZNFAjnC2X2Pe825E5xgzlzQ9g0baZZuHoSbhlKgIoFj z6aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=HGY8EtWSbvalPN/NJYlL83ezJYxbqwC1stlclvRCd58=; b=gcTDcoDHv/u4Fl1i//6hRxgWVUAwfnDERkyhKnr4A58iU3LnSkKQ7ixeDA6/2fiNAX cP24Oi4JtsymD7eg58bmlkhvRoAGnZGSl0uA9ukNE4TsqXJnn5cUlxFFKbBXQzX8CxuL hWxK0DTXbJMahmRUvFYRdW8zH+nMFaHxzxEXiGC/gRH+YO0C5Zd4MnFGMpe/XF/+jKu0 8WOCzOtpDqgbpctaGW217kVgEGhJaCsLpAc6aoEuncgacFPYkk0AYXAqm5LuHgA4IIEi PPkXLBBWNkbRbSRD7HOCReq6VhwNt9w59ZqsaPZb8Ob7ghrkiCnbytn58T/+5RLWf/ss xHsQ== X-Gm-Message-State: AKGB3mKc/do4LmjEgSODgolMhpnkujUqmnyAgGKoSUHX+PMVJzgfNauw SXoUWjCaztROP+vW2Wkms5yKupRIkjY= X-Google-Smtp-Source: ACJfBotJv9irCVibKx41jIOAdHAAAYNh+tlcXT4UiF/IVI5gluwI9EM2w9giWXuxnY1mafVg2T/9ww== X-Received: by 10.36.166.13 with SMTP id q13mr5215838ite.37.1515221009378; Fri, 05 Jan 2018 22:43:29 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] prevent parameters leaking from various completers From: dana In-Reply-To: <20171226021740.81700-1-llua@gmx.com> Date: Sat, 6 Jan 2018 00:43:27 -0600 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: <185B6D54-C800-46AF-9BEC-7B5A0AA04046@dana.is> References: <20171226021740.81700-1-llua@gmx.com> To: Eric Cook X-Mailer: Apple Mail (2.3273) On 25 Dec 2017, at 20:17, Eric Cook wrote: >- local desc=3D >+ local desc=3D input I noticed that this fouls up git completion. The first time i do `git = add whatever`, it prints out a bunch of garbage (since this is = happening in a loop and typeset_silent isn't set). Fix attached. Also, in _cd, we're marking match, mbegin, and mend as integers when = they're actually arrays. I don't think that will hurt anything, but...? dana diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index a46da5b3c..bf5c1e702 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -7727,7 +7727,7 @@ for file in ${^fpath}/_git-*~(*~|*.zwc)(-.N); do continue fi =20 - local desc=3D input + local desc=3D input=3D integer i=3D1 while read input; do if (( i =3D=3D 2 )); then diff --git a/Completion/Zsh/Command/_cd b/Completion/Zsh/Command/_cd index 46237e73d..32f53a78b 100644 --- a/Completion/Zsh/Command/_cd +++ b/Completion/Zsh/Command/_cd @@ -21,8 +21,8 @@ _cd_options() { =20 setopt localoptions nonomatch =20 -local expl ret=3D1 curarg -integer argstart=3D2 noopts match mbegin mend +local expl ret=3D1 curarg match mbegin mend +integer argstart=3D2 noopts =20 if (( CURRENT > 1 )); then # if not in command position, may have options.