From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] [[:blank:]] only matches on SPC and TAB
Date: Tue, 15 May 2018 21:06:01 +0200 [thread overview]
Message-ID: <18720.1526411161@thecus> (raw)
In-Reply-To: <20180514155131.GC7263@chaz.gmail.com>
Stephane Chazelas wrote:
> [...]
> > It wouldn't be ridiculous to change the documentation for this case and
> > require "unsetopt multibyte" for strict byte-by-byte comparisions, which
> > is already how it works in the vast majority of other cases.
> [...]
>
> But note that here it's not about multibyte vs singlebyte but
> whether [:blank:] honours the locale like the other POSIX
> character classes (alpha, punct...) do.
For consistency with the other character classes, I think the best is to
follow POSIX and the other shells and have [:blank:] call iswblank().
That is apply the patch plus whatever change the documentation needs to
reflect it.
I can't see it actually breaking scripts in practice. We do at least
have the option of using [$' \t'] if we want and could add [[:BLANK:]]
or similar if needed. It does seem wrong for non-breaking spaces to be
matched but that's an issue for NetBSD or whatever.
This isn't as bad as the idiocy of [a-z] matching B-Z.
> What a mess!
Indeed.
I also wish POSIX would standardise an alternative for the C locale
that's UTF-8 aware and with ISO rather than US format dates.
Oliver
next prev parent reply other threads:[~2018-05-15 19:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 21:25 Stephane Chazelas
2018-05-13 21:49 ` [PATCH v2] " Stephane Chazelas
2018-05-14 2:27 ` [PATCH] " Sebastian Gniazdowski
2018-05-14 4:41 ` Sebastian Gniazdowski
2018-05-14 6:36 ` Stephane Chazelas
2018-05-14 6:44 ` Stephane Chazelas
2018-05-14 8:47 ` Peter Stephenson
2018-05-14 12:34 ` Stephane Chazelas
2018-05-14 13:50 ` Peter Stephenson
2018-05-14 15:51 ` Stephane Chazelas
2018-05-14 16:31 ` Sebastian Gniazdowski
2018-05-14 16:50 ` Bart Schaefer
2018-05-14 19:52 ` Daniel Tameling
2018-05-14 20:42 ` Stephane Chazelas
2018-05-15 18:12 ` Stephane Chazelas
2018-05-16 4:18 ` Sebastian Gniazdowski
2018-05-15 19:06 ` Oliver Kiddle [this message]
2018-05-16 13:15 ` Stephane Chazelas
2018-05-16 13:40 ` Peter Stephenson
2018-05-16 16:31 ` Stephane Chazelas
2018-05-16 21:02 ` [PATCH v4] " Stephane Chazelas
2018-05-17 8:29 ` Peter Stephenson
2018-05-17 22:05 ` [PATCH] " Oliver Kiddle
2018-05-17 9:03 ` Sebastian Gniazdowski
2018-05-17 10:10 ` Sebastian Gniazdowski
2018-05-14 8:11 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18720.1526411161@thecus \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).