From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34046-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 5070 invoked by alias); 23 Dec 2014 00:33:14 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34046
Received: (qmail 24864 invoked from network); 23 Dec 2014 00:33:11 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1419294459; bh=GFkH+B1q2yK9MvsPBp+YWetYQ4/008TgJ0zHBEQBRzA=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=te77msr6Av35B6CxONgTKFevYGp8L+tYnMxrBshx783JdXJi0tg8jzM3oJ7HsukEzhxrWqTC94jK662291lWa4V0EUIRPDKcKGwPRO3MrIz6C4nbG9HRNipqQYNPqgUSmT7pyoIE69iPWCqp5ghOf+zeWQsiaItFpBtkYDX0VqXvDgQmsdhAIR6NGuALWyvQSpYOiFou3M3AmvA9oMyBFAL3b1pSVMgEM2koAuqxZnEMcdPSdb7BBG+QiEV8q2atRdQQDHf/dcwxCTrko4rRXn2BiL06cLNQo4Txh9mIqtO7HneD5c+TsGaROxIF1+wIChNJn6fTO0Wut6BvF8BXeg==
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.co.uk;
	b=k0EvZo6gT0UsniOgVBRQmhuS6JVKcLfOLTRKskRdIy2xv6nICh2tVYpsoWNcUFlpOSPb4mpOkVXMD4kBmrMFcZ+WZpvg+h82bVMfqc5u5mXUw8ekMixWP3AfoCr1nSeXuTkqR+6Q9yA4j7oCnRzkLAqqsFrIq+tZ3zlCexM3LNW4I/T3eut5HKSQ7WOY5jYjBQvDbWKgiyNOZoqmpzoJtWVQJsy21ni4KOf0SFIdK1CBVpasSgNahSdp7rmYzTGqQOGsWfK4/TgFdsyFcsQLFa6/bWbsbN6pDlCevClmyu/LKVBs/vEs4TtrfWmlTpiVpbbzKLUTXtAJL5JlROcZpQ==;
X-Yahoo-Newman-Id: 242957.58800.bm@smtp117.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: ayTkzpUVM1mjUoE7ZnMdj1aA1FoYFHQSlQGUdfsXCr.vFWL
 raHcVgGcrSYSVylLr1WMVjPihKFfqJTBdiae4rL7e8xUvslMNBe96DGVK1wF
 9ExxkOSUwjaOZi6O9jWviIeAdL0nNd.IROgV2OmC0_JE6xMn4QmmLiQvOeDM
 pQaeVbNSDPE5vWnyCzlnoaIMWZvdlk8nkqRrlVCzLs5BzubRtt99SCU7LD2.
 QFsaLRGXply18TmFXU2V71CC4L9Q.8J2pvkndiKmCl2gJtURk8cTgEWNoYtZ
 5n13VBL.A1kWqaYYh2y5uOQlsDFqncBOcJzVxuLyLuQQ96Cqdc93xUfulh3K
 dLRckjF9MQ63X6PqFqIiUKhIaMB75qgtymyYMDSTiME4KBerqqkbEbxlA1ED
 f7QnmPJX_1V7rj1jjb5GZbEWzVvtdI0t4lCWzmoBZNTAlAdZrQZnMx_5SB9i
 4U8dAPYp6_S_SSe9qDTtLRm87Gh8yesGxReN8YoLI.KYd66_92owQQt3Yf2d
 54bd_17jlMgc9EVChBcf_qOXtw_tzsQ--
X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI-
In-reply-to: <CAHYJk3Q7Y2kF8tGvg_BnAVmjtFEy41oFTz1tbqUex=kqQ7JPnw@mail.gmail.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <20141222204546.GC15399@tarsus.local2> <CAHYJk3Q7Y2kF8tGvg_BnAVmjtFEy41oFTz1tbqUex=kqQ7JPnw@mail.gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] _git: Respect tags for subcommand completion.
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18764.1419294457.1@thecus.kiddle.eu>
Date: Tue, 23 Dec 2014 01:27:38 +0100
Message-ID: <18765.1419294458@thecus.kiddle.eu>

Mikael Magnusson wrote:
> > Attached a patch to improve the 'git <TAB>' user experience.
> 
> Could you write a few words about what the patch actually does? Eg,
> what's wrong with the current status quo?

Did you perhaps not notice the subsequent text in the lead up to the
patch?

The current code is not using a single tag loop for all of the different
types of commands. The default behaviour won't change much but with
the tag-order style, you will be able to reorder the commands or have
certain types only completed if others don't match or if _next_tags is
invoked.

Oliver