zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zmodload (-u?) changing options (was Re: [PATCH] Named reference typos & misc.)
Date: Tue, 21 Feb 2023 12:11:55 +0000 (GMT)	[thread overview]
Message-ID: <1877364146.2297030.1676981515507@mail.virginmedia.com> (raw)
In-Reply-To: <338705584.2294040.1676980051672@mail.virginmedia.com>

> On 21/02/2023 11:47 Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> The point where the invalid memory is being accessed is therefore
> apparently using an autoload stub when the full parameter has
> already been loaded.  So is the code in question hanging onto
> a parameter pointer that it should instead be looking up again
> after some complicated intervening operation that happens to do
> the autoload?

Yes, here.  "zmodload -u zsh/parameter" followed by completion
gave me enough information.  This removes the errors from that
case, so hopefully will get rid of the test problems too.

This can't be wrong, I'll commit it.

pws

diff --git a/Src/params.c b/Src/params.c
index e940d7995..90302b1b0 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -538,7 +538,7 @@ getparamnode(HashTable ht, const char *nam)
     }
 
     if (hn && ht == realparamtab)
-	hn = resolve_nameref(pm, NULL);
+	hn = resolve_nameref((Param)hn, NULL);
     return hn;
 }


  reply	other threads:[~2023-02-21 12:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  2:08 [PATCH] Named reference typos & misc Bart Schaefer
2023-02-14 14:46 ` Peter Stephenson
2023-02-14 16:14   ` Bart Schaefer
2023-02-14 16:36     ` Peter Stephenson
2023-02-14 20:00       ` Bart Schaefer
2023-02-15  1:39         ` Bart Schaefer
2023-02-16 15:29           ` zmodload (-u?) changing options (was Re: [PATCH] Named reference typos & misc.) Bart Schaefer
2023-02-16 15:52             ` Peter Stephenson
2023-02-16 18:17               ` Bart Schaefer
2023-02-16 19:28                 ` Bart Schaefer
2023-02-16 23:10                 ` Bart Schaefer
2023-02-21 11:47                 ` Peter Stephenson
2023-02-21 12:11                   ` Peter Stephenson [this message]
2023-02-21 15:57                     ` Bart Schaefer
2023-02-15 10:12         ` [PATCH] Named reference typos & misc Peter Stephenson
2023-02-15 10:36           ` Peter Stephenson
2023-02-15 14:58             ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1877364146.2297030.1676981515507@mail.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).