From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG] malloc inside signal handler
Date: Tue, 17 Aug 2021 09:21:35 +0100 (BST) [thread overview]
Message-ID: <1888954006.948395.1629188495083@mail2.virginmedia.com> (raw)
In-Reply-To: <CAH+w=7YevRsxGOV_USF0C6Krgxj=h9YB3TQmsMV55q6C1=UX5Q@mail.gmail.com>
> On 17 August 2021 at 05:20 Bart Schaefer <schaefer@brasslantern.com> wrote:
> Or maybe shingetline() doesn't actually need to call winch_unblock()
> when loop(0,...) is called and isatty(bshin) is false ... which means
> passing the value of toplevel down from loop(). But that probably
> just fixes adjustwinsize() and leaves other signal handlers
> unprotected.
Might be worth doing anyway, since adjustwinsize() is the one that's doing
the big allocation within the signal code. I haven't checked, but I
doubt there's anything like that in the others.
Avoiding stdio for input of this sort doesn't actually look infeasible,
either --- mentions of bshin (buffered shell input from files) are
restricted to only a couple of files. But it's kind of annoying as this
is exactly the job stdio is designed for.
pws
next prev parent reply other threads:[~2021-08-17 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 22:50 zsugabubus
2021-07-31 1:33 ` Bart Schaefer
2021-07-31 20:25 ` zsugabubus
2021-08-17 4:20 ` Bart Schaefer
2021-08-17 8:21 ` Peter Stephenson [this message]
2021-08-18 19:27 ` Peter Stephenson
2021-08-26 15:46 ` Peter Stephenson
2021-08-26 15:51 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1888954006.948395.1629188495083@mail2.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).