zsh-workers
 help / color / mirror / code / Atom feed
From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Peter Grayson" <pete@jpgrayson.net>
Cc: zsh-workers@zsh.org
Subject: StGit 2.0 and vcs_info (was: Re: [PATCH] Remove _stgit completion script)
Date: Mon, 31 Oct 2022 10:13:50 +0000	[thread overview]
Message-ID: <18f5d6c6-f9f6-4626-ab9d-fe078260ee75@app.fastmail.com> (raw)
In-Reply-To: <20221031091933.GE27622@tarpaulin.shahaf.local2>

Daniel Shahaf wrote on Mon, 31 Oct 2022 09:19 +00:00:
> Peter Grayson wrote on Tue, Oct 25, 2022 at 16:43:21 -0400:
>> Also, the _stgit completions that ship with zsh, which dynamically parse
>> StGit's help output, will be broken by the upcoming StGit 2.0 release
>> due to changes in the help output.
>> 
>
> StGit is also used by vcs_info, here:
>
> https://github.com/zsh-users/zsh/blob/b76dcecfe3461aa9a9e29dffe2484f097611f9ff/Functions/VCS_Info/Backends/VCS_INFO_get_data_git#L187-L194
>
> (There doesn't seem to be StGit-specific code elsewhere in the file or
> in the sibling file VCS_INFO_detect_git.)
>
> Any chance that someone who uses both StGit and zsh could review that?
> That code is supposed to populate $gitmisc (and thus the %m expando)
> with information about pushed and not-yet-pushed patches.
>
> To test that:
>
> [[[
> autoload vcs_info
> precmd() { vcs_info }

Need to emit ${vcs_info_msg_0_} as well (see Misc/vcs_info-examples).

> zstyle ':vcs_info:*' formats %m
> zstyle ':vcs_info:*' actionformats %m
> ]]]

Cheers,

Daniel


  reply	other threads:[~2022-10-31 10:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25 20:43 [PATCH] Remove _stgit completion script Peter Grayson
2022-10-31  9:19 ` Daniel Shahaf
2022-10-31 10:13   ` Daniel Shahaf [this message]
2022-11-01  3:00   ` Peter Grayson
2022-11-01  3:04     ` [PATCH] Remove StGit patch detection from vcs_info Peter Grayson
2022-11-11 11:49       ` Daniel Shahaf
2022-11-12 14:46         ` Peter Grayson
2022-11-12 15:42           ` [PATCH] Updated StGit patch detection in vcs_info Peter Grayson
2022-11-13  4:58             ` Daniel Shahaf
2022-11-16 20:45             ` [PATCH v2] " Peter Grayson
2022-12-08 14:52               ` [PATCH v3] " Peter Grayson
2022-12-08 22:06                 ` Daniel Shahaf
2022-12-08 22:08                   ` [PATCH] vcs_info git: Check the get-unapplied style as documented (was: [PATCH v3] Updated StGit patch detection in vcs_info) Daniel Shahaf
2022-12-09  0:59                   ` [PATCH v3] Updated StGit patch detection in vcs_info Peter Grayson
2022-12-09  1:37                     ` Daniel Shahaf
2022-12-10 12:55                       ` Peter Grayson
2022-12-10 13:31                         ` Daniel Shahaf
2022-11-13  4:30           ` [PATCH] Remove StGit patch detection from vcs_info Daniel Shahaf
2022-11-14  3:38             ` Peter Grayson
2022-11-14  5:17               ` Mikael Magnusson
2022-11-14 13:21                 ` Daniel Shahaf
2022-11-14 13:15               ` Daniel Shahaf
2022-11-16 19:38                 ` Peter Grayson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18f5d6c6-f9f6-4626-ab9d-fe078260ee75@app.fastmail.com \
    --to=d.s@daniel.shahaf.name \
    --cc=pete@jpgrayson.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).