From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38732-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 29762 invoked by alias); 21 Jun 2016 11:22:18 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38732
Received: (qmail 28809 invoked from network); 21 Jun 2016 11:22:16 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1466508131; bh=nwQCbrjGc9YmhSr2svIG2Ai7TFkbcoCn6sDpM+byR1M=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=c2ajAlNbXMGuBXmo8U2nhMVJJhQuVQFKZ33riLzJnmjZEa8HqH4GJt3I6VLj47W155aaQZ/a9l3MiaxJBpxoOfPUZl/CgRg4eJgdv2eBwg/5CsbTVatfagNZuP0bty7bzvFfhI6opqan6x7uT3S1dFmrBzdrpPpLlfeAaK1EchqwbVKyFmDzHR7eQogEkkqydaGzhg5NwGjV4PfWdoUvZRzlJiHTp/T6X7e7J7lqzqh4LekdNxKNq7k49kF3p4TM8uFF9xJMMdPTW9nvm/eOhPQYoHfPQt3CTGbNwSXPBM4H0dg6lwyRMEM0lfJO3+ouIv9xNiPGeybzrWvOwHUaJQ==
X-Yahoo-Newman-Id: 31184.62174.bm@smtp106.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: 8mtuB.UVM1myhh9441iKbZF35T1EnfkC00PMYYL1aJ_chdf
 VExh5sHfFzgl6Xw.2u2hYr4hK25GKkhpyaeqsas8FmpOkAllzh1htLHMLRks
 2a0CjDZA6WYzel7y6UuGJG7ENC9vTQyppOJvT9X2hZwtC2qaJHXa31DQeBAY
 41At.Y2b3arSHYy73vLHx_SQkVwz7dZsbdxCUEhnjd_yUluD_MM80ef66e.1
 pfX4DEACiylJVYVM4Z8lOegpZ_pyDGOoG5q6nhMEMo0PaOJIdTnYryJMPqi.
 jLX_.pXmuBFols3cq1qSbCmTcGws4Aej59.5EiFO00wZKM7nzkNWqpa10mEc
 wPpMuk6GpE4OIPtrxZQCIDK7HegSQMTx0phF6RxzP8g6gbAgAX4Y6iGotYlb
 HBJvLEOgl_adVGYSuoH9nvxTEMTljiznahjvT4ZXKD0U07YcY3v0fIi02Asb
 YcSIHWKwEKoS4aYiaiqql95qObNt2szrYNn0JOjnbjgy9ZAX7OUC9EqlTxFA
 cUMD0CWSkSkYWiYC1hGY_kTqYyTRBwg--
X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI-
In-reply-to: <20150517215341.223ef620@ntlworld.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <20150517215341.223ef620@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: case pattern parsing
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19006.1466508129.1@thecus.kiddle.eu>
Date: Tue, 21 Jun 2016 13:22:09 +0200
Message-ID: <19007.1466508129@thecus.kiddle.eu>

On 17 May 2015, Peter wrote:
> This patch parses case patterns properly, removing the hack that

I noticed a bug with case statements which git bisect tracks to this
change (workers/35168 or 52aeb9aa). It occurs with a fall-through at the
end of the case statement:

  case whatever in
    *) ;&
  esac

I'm not sure how reproducible it is - seems to be fine on Solaris.
#0  0x000000000042e8bd in execlist (state=0x7ffce20a9ac0, dont_change_job=1,
    exiting=0) at exec.c:1195
1195    code = *state->pc++;
#1  0x000000000046587e in execcase (state=0x7ffce20a9ac0, do_exec=0) at loop.c:669
#2  0x000000000042e7b3 in execsimple (state=0x7ffce20a9ac0) at exec.c:1141
#3  0x000000000042eb28 in execlist (state=0x7ffce20a9ac0, dont_change_job=0, 
    exiting=0) at exec.c:1265
#4  0x000000000042e41b in execode (p=0x7f377b419418, dont_change_job=0, exiting=0, 
    context=0x4bded7 "toplevel") at exec.c:1085
#5  0x000000000045201b in loop (toplevel=1, justonce=0) at init.c:208
#6  0x0000000000455bde in zsh_main (argc=1, argv=0x7ffce20a9e28) at init.c:1688
#7  0x000000000040f640 in main (argc=1, argv=0x7ffce20a9e28) at ./main.c:93

Oliver